Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress code location errors by default and in debug mode, show the list of unsupported ops in debug mode for better readability. #932

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Suppress code location errors by default and in debug mode, show the list of unsupported ops in debug mode for better readability. #932

merged 3 commits into from
Apr 5, 2022

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Mar 17, 2022

Description

Suppress code location errors by default and in debug mode, show the list of unsupported ops in debug mode for better readability.

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (By default, unsupported op code location messages are printed as ERRORs which is misleading).

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@peri044 peri044 requested a review from narendasan March 17, 2022 06:01
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler labels Mar 17, 2022
peri044 added 2 commits March 16, 2022 23:01
@peri044
chore: Suppress code location errors by default and in debug mode, sh…
0b8321b 
…ow the list of unsupported ops

Signed-off-by: Dheeraj Peri <[email protected]>
@peri044
chore: removing irrelevant fix
5c26000 
Signed-off-by: Dheeraj Peri <[email protected]>
github-actions[bot]
github-actions bot approved these changes Mar 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@peri044 peri044 mentioned this pull request Mar 18, 2022
Merged
6 tasks
github-actions[bot]
github-actions bot approved these changes Mar 23, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 23, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@peri044
chore: Rebase with master
780fd4f 
Signed-off-by: Dheeraj Peri <[email protected]>
narendasan
narendasan approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit e38056b into master Apr 5, 2022
@narendasan narendasan deleted the log_fix branch April 5, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan narendasan approved these changes

Assignees
No one assigned
Labels
component: conversion Issues re: Conversion stage component: core Issues re: The core compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peri044 @narendasan