Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aten::pow support #918

Merged
merged 4 commits into from
Mar 22, 2022
Merged

aten::pow support #918

merged 4 commits into from
Mar 22, 2022

Conversation

narendasan
Copy link
Collaborator

@narendasan narendasan commented Mar 8, 2022 •
edited
Loading

Description

Improves some debugging tools and implements an aten::pow evaluator.

Partially addresses #833
Fixes: #923

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan
chore: Adding a nox session to download all the models for you
06baa81 
Running `nox --session download_test_models-3` will download
all the models used in testing for you

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
@narendasan
feat(//core/conversion): Better tooling for debugging
c5c5c47 
Clarifying some error messages and better controlling
suppressed errors for op support

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
@narendasan
feat(//core/conversion/evaluators): aten::pow support
c4fdfcb 
Adds support for the following aten::pow variants in the evaluator
library

```
 	"aten::pow.int(int a, int b) -> (float)",
        "aten::pow.float(float a, float b) -> (float)",
        "aten::pow.int_float(int a, float b) -> (float)",
        "aten::pow.float_int(float a, int b) -> (float)",
```

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
@narendasan
refactor: apply linting
8b33dc0 
Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
@narendasan narendasan requested a review from peri044 March 8, 2022 03:26
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests labels Mar 8, 2022
github-actions[bot]
github-actions bot approved these changes Mar 8, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 8, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 8, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 8, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

This was referenced Mar 8, 2022
Closed
Closed
@peri044
Copy link
Collaborator

peri044 commented Mar 18, 2022 •
edited
Loading

@narendasan
#932 has some logging changes too as follows
In debug mode, we just list out the operators which are unsupported.
For people really interested in knowing which pytorch source code line is responsible for unsupported op, they need to call conversion::VerifyConverterSupportForBlock(g->block(), false) (suppress_errors=False). Let me know what you think ?
(or)
we can bump display of unsupported ops list to info and code location errors to debug

@narendasan
Copy link
Collaborator Author

The unsupported ops will still get printed here, just at a lower severity

@peri044 peri044 merged commit 4839b11 into master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@peri044 peri044 peri044 approved these changes

Assignees
No one assigned
Labels
component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Log print misleading error messages when there is unsupported operator
2 participants
@narendasan @peri044