Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aten extend #892

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Support aten extend #892

merged 3 commits into from
Feb 25, 2022

Conversation

narendasan
Copy link
Collaborator

Description

Support aten::extend evaluator. The Function schema is "aten::extend.t(t self, t[] other) -> ()"

Changes some rules about Vars in the conversion context, allowing evaluators to request mutable handles to support in-place operations explicitly

Closes #704

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

ruoqianguo and others added 3 commits February 23, 2022 18:59
@ruoqianguo @narendasan
feat: support aten::extend evaluator
33c523d 
Signed-off-by: Ruoqian Guo <[email protected]>
@ruoqianguo @narendasan
chore: return self in aten::extend
e1b68fc 
Signed-off-by: Ruoqian Guo <[email protected]>
@narendasan
refactor(//core/conversion/var): Modify var contract
97eb4eb 
This modifies the variable contract to allow requesting of
mutable handles to `IValue`s which previously were provided
only as `const`. Now every IValue pointer is not `const` within
`Var`, but in order to get a `const` handle you use IValueMut.

This supports the evaluation of inplace operations and makes
state changes explicit rather than implicit.

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests labels Feb 24, 2022
github-actions[bot]
github-actions bot approved these changes Feb 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

peri044
peri044 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass. LGTM

@peri044 peri044 merged commit ef62f6b into master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narendasan @peri044 @ruoqianguo