Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support aten::extend evaluator #704

Closed
wants to merge 2 commits into from

Conversation

ruoqianguo
Copy link
Contributor

Signed-off-by: Ruoqian Guo [email protected]

Description

Support aten::extend evaluator. The Function schema is "aten::extend.t(t[](a!) self, t[] other) -> ()"

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

"Unimplemented data type for aten::extend.t evaluator: "
<< args.at(n->input(0)).IValue()->type()->str() << ", "
<< args.at(n->input(1)).IValue()->type()->str());
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function doesnt return anything. While you might be modifying state correctly, we want to make transforms as functional as possible. Create a copy of self, modify it and return that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @narendasan , i tried to return self, but the output of node aten::extend.t(t[](a!) self, t[] other) -> () is None. It will occurs an error in there like C++ exception with description "vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function doesnt return anything. While you might be modifying state correctly, we want to make transforms as functional as possible. Create a copy of self, modify it and return that

I return self in aten::extend evaluator and add a condition to estimate the number of ouputs in ConvertBlockToNetDef.

@github-actions
Copy link

This PR has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants