Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content to the "About Us" section #117

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

akshay196
Copy link
Contributor

@akshay196 akshay196 commented Jul 28, 2020

This PR added the text content to the "About Us" section on homepage.

Ref: pythonpune/design#2

config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
@akshay196
Copy link
Contributor Author

@bhavin192 Thanks for your suggestions. All the suggested changes are made.

Copy link
Member

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@girish946 girish946 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@digitronik digitronik self-assigned this Aug 2, 2020
@digitronik
Copy link
Member

LGTM 💯 Please don't merge this tomorrow I will push this; currently fixing linkstatus behaviour.

Copy link
Contributor

@bhavin192 bhavin192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to include few of the important points which we were missing. For example, link to CoC, DevSprints and new talk proposal.

config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Show resolved Hide resolved
Copy link
Contributor

@raukadah raukadah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, rest looks good.

@digitronik
Copy link
Member

LGTM Please don't merge this tomorrow I will push this; currently fixing linkstatus behaviour.

Thanks for waiting @akshay196 ... from my side CI error resolved. As per current run schema missing i.e. links without http/https. You can ignore them.

@digitronik
Copy link
Member

btw @bhavin192 why you removed label? Adding label is bad practice?

@digitronik digitronik removed their assignment Aug 2, 2020
@akshay196
Copy link
Contributor Author

@bhavin192 I have update the content as per your suggestions.

@bhavin192 bhavin192 merged commit 58fd176 into pythonpune:master Aug 4, 2020
@akshay196
Copy link
Contributor Author

@bhavin192 Thank you for reviewing and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants