Fix tqdm.asyncio type inconsistency #13259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Dec 18, 2024
stubs/tqdm/tqdm/asyncio.pyi
Outdated
| @@ -84,7 +84,7 @@ class tqdm_asyncio(std_tqdm[_T]): | |||
| @overload | |||
| def __init__( | |||
| self, | |||
| iterable: Iterable[_T], | |||
| iterable: Iterable[_T] | Iterator[_T] | AsyncIterator[_T], | |||
There was a problem hiding this comment.
Iterable is redundant, as each Iterator is an Iterable.
Suggested change
| iterable: Iterable[_T] | Iterator[_T] | AsyncIterator[_T], | |
| iterable: Iterator[_T] | AsyncIterator[_T], |
There was a problem hiding this comment.
Iterable[_T] is still a valid type, so Iterator[_T] should probably be removed instead.
There was a problem hiding this comment.
Looks to me that @mattmess1221 is correct, just because this code fallsback to iter(iterable), so they will create an Iterator themselves from Iterable.
The code in question: https://github.com/tqdm/tqdm/blob/0ed5d7f18fa3153834cbac0aa57e8092b217cc16/tqdm/asyncio.py#L26-L34
There was a problem hiding this comment.
You are correct, of course. Iterator is redundant.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13227