Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tqdm.asyncio type inconsistency #13227

Closed
mattmess1221 opened this issue Dec 10, 2024 · 0 comments · Fixed by #13259
Closed

tqdm.asyncio type inconsistency #13227

mattmess1221 opened this issue Dec 10, 2024 · 0 comments · Fixed by #13259

Comments

@mattmess1221
Copy link

The signature of tqdm_asyncio.__init__ wrongly uses iterable: Iterable[_T] when it should beiterable: Iterable[_T] | Iterator[_T] | AsyncIterator[_T].

The implementation checks for __anext__ and __next__, falling back to iter().

https://github.com/tqdm/tqdm/blob/0ed5d7f18fa3153834cbac0aa57e8092b217cc16/tqdm/asyncio.py#L26-L34
kbaikov added a commit to kbaikov/typeshed that referenced this issue Dec 17, 2024
@kbaikov
Fix tqdm.asyncio type inconsistency
9a1f6dd 
Fixes python#13227
@kbaikov kbaikov mentioned this issue Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tqdm.asyncio type inconsistency kbaikov/typeshed
1 participant
@mattmess1221