Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type all @property in openpyxl #10787

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Sep 28, 2023

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't compare this to the implementation, but this all looks reasonable to me.

@srittau srittau merged commit c30c85d into python:main Oct 4, 2023
46 checks passed
@Avasam Avasam deleted the openpyxl-properties branch October 4, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openpyxl Worksheet columns is incorrectly typed
2 participants