Merge openpyxl stubs from microsoft/python-type-stubs #9511
Conversation
…xl-from-microsoft-python-type-stubs
…xl-from-microsoft-python-type-stubs
This comment has been minimized.
This comment has been minimized.
|
(Adding DO-NOT-MERGE for now, as I agree we should resolve #9487 first before tackling this :) |
|
In the meantime, @AlexWaygood , can we consider allowing lxml-stubs in the stubuploader? Also, is there a list somewhere of those "stubs taken out of typeshed because incomplete"? I feel it shouldn't be too hard to add 'em back with modern stubgen. |
SGTM but I'm not a stub-uploader maintainer :) |
Not sure I understand, sorry -- what's this a reference to? |
https://pypi.org/project/lxml-stubs/
I feel it's not the first time I see that. Or maybe it is and I just read it twice on the same page. |
|
You'll have to ask one of the other maintainers -- sounds like that all happened before I arrived on the typeshed scene! |
This comment has been minimized.
This comment has been minimized.
On second thought -- with our current setup, I think you'll be unable to use This is an annoying situation but I'm not sure what the solution might be. |
…xl-from-microsoft-python-type-stubs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…xl-from-microsoft-python-type-stubs
…ithub.com/Avasam/typeshed into openpyxl-from-microsoft-python-type-stubs
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
…xl-from-microsoft-python-type-stubs
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
…xl-from-microsoft-python-type-stubs
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
…xl-from-microsoft-python-type-stubs
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@Avasam this is now the oldest open PR and CI is green, but it's still in draft. Is it ready now? If not, what is the plan for this PR? |
|
I've been extracting changes by scope and concepts they relate to, which allowed me to validate the changes actually made sense and fix entire sections of openpyxl stubs at once. (this PR started with over 80 files changed) The only thing left here would be a PR that covers adding annotations for openpyxl Cell Values and that should close this PR. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
…hub.com/Avasam/typeshed into openpyxl-from-microsoft-python-type-stubs
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
…xl-from-microsoft-python-type-stubs
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Bring openpyxl stubs at least up to par with https://github.com/microsoft/python-type-stubs/tree/main/openpyxl
Add class variable types and descriptors for affected classes.
For a bit of context: "descriptor" types are assigned to class variables. Those become property-like with getters that type-check on assignment.
There's also "Convertible" descriptors that do type coercion.
This is not meant to complete the stub, far from there. Only to make it good enough to upstream. And a few other things here and there.
There's overlap with
#9487#9764, I'd suggest finishing that PR first, then I'll double check any conflict that arise.I'll look at primer results after that as well.