gh-93274: Disable Limited API tests with Py_TRACE_REFS #95796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
vstinner
reviewed
Aug 8, 2022
| @@ -1,3 +1,16 @@ | |||
| #include "pyconfig.h" // Py_TRACE_REFS | |||
|
|
|||
| #ifdef Py_TRACE_REFS | |||
There was a problem hiding this comment.
I would suggest to move this #ifdef in _testcapimodule.c instead.
| // Py_TRACE_REFS is incompatible with Limited API | ||
| #include "parts.h" | ||
| int | ||
| _PyTestCapi_Init_VectorcallLimited(PyObject *m) { |
There was a problem hiding this comment.
I suggest putting an #ifdef on the _PyTestCapi_Init_VectorcallLimited() call in _testcapimodole.c instead of defining a no-op function.
Maybe define somewhere a macro to decide if vectorcall is tested or not? Something like:
#ifndef Py_TRACE_REFS
# define TEST_VECTORCALL
#endif
|
If the tests pass, I'll merge this as is and make it better later. I'd like to make testing limited API as smooth as possible, which'll be much easier without the pressure of a red buildbot. |
This was referenced Aug 9, 2022
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the Py_TRACE_REFS buildbot.
(In the future we'll need a better way to write limited API tests.)