gh-93274: Expose receiving vectorcall in the Limited API #95717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
encukou
commented
Aug 5, 2022
•
encukou
commented
- Issue: Receiving vector calls in the Py_LIMITED_API #93274
|
This looks great. Leaving |
erlend-aasland
approved these changes
Aug 5, 2022
Objects/call.c
Outdated
| @@ -1047,3 +1047,11 @@ _PyStack_UnpackDict_Free(PyObject *const *stack, Py_ssize_t nargs, | |||
| PyMem_Free((PyObject **)stack - 1); | |||
| Py_DECREF(kwnames); | |||
| } | |||
|
|
|||
| // Export for the stable ABI | |||
| #undef PyVectorcall_NARGS(n) | |||
There was a problem hiding this comment.
Suggested change
| #undef PyVectorcall_NARGS(n) | |
| #undef PyVectorcall_NARGS |
|
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Aug 8, 2022
pythonGH-95717)" This reverts commit 656dad7.
|
If anyone needs the TraceRefs buildbot green, please merge the revert. I'm working on a fix, so maybe a revert won't be necessary. |
|
https://buildbot.python.org/all/#builders/484/builds/1920 failed to build:
IMO it's ok if it's broken for a few days, but it would be nice to fix it before next Python (3.12) release. |
|
This'll hopefully fix it: #95796 |
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.