-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change some mercurial/ hg.python.org references. #8
Conversation
You may also update:
For benchmarks, please point to the new project: https://github.com/python/performance By the way, you might use reST syntax for links to enhance formatting. |
Doc/faq/general.rst
Outdated
@@ -222,7 +222,7 @@ releases are announced on the comp.lang.python and comp.lang.python.announce | |||
newsgroups and on the Python home page at https://www.python.org/; an RSS feed of | |||
news is available. | |||
|
|||
You can also access the development version of Python through Mercurial. See | |||
You can also access the development version of Python through Git. See | |||
https://docs.python.org/devguide/faq.html for details. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devguide URL should be updated to http://cpython-devguide.readthedocs.io.
Also, the FAQ has been removed from the Dev Guide, so the section you want is perhaps http://cpython-devguide.readthedocs.io/communication.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.python.org/devguide
is still correct, but the lack of faq does need to be fixed. Perhaps just remove the /faq.html
part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one correct URL is better.
At least, https://docs.python.org/devguide doesn't switched to github version yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update:
https://docs.python.org/devguide has been updated to github.
At the moment /faq.html is still alive, but will be removed soon (see python/devguide#114)
Let's remove the reference to faq.html here :)
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 83.39% 82.37% -1.03%
==========================================
Files 1367 1427 +60
Lines 344829 350948 +6119
==========================================
+ Hits 287563 289083 +1520
- Misses 57266 61865 +4599 Continue to review full report at Codecov.
|
Thanks for the review comments, @Haypo , @Mariatta . I've addressed them
Please review again, if good to go, I am willing to try our merge process with merging this to master and cherrying pick to other active branches. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Note that you probably should use needs backport to X.Y
labels instead of cherry-pick for X.Y
.
Thanks @berkerpeksag for your review. |
workaround optimizer problem
8: Add warnings for strings and operations r=ltratt a=nanjekyejoannah This PR adds warnings about: - the unicode type - the `ur` literal - the incompatible `basetring type' - and mixed concat operations for strings Co-authored-by: Joannah Nanjekye <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
No description provided.