Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to 3.6] bpo-29529: Add .travis.yml to 3.6 branch #25

Merged
merged 4 commits into from
Feb 19, 2017

Conversation

methane
Copy link
Member

@methane methane commented Feb 11, 2017

No description provided.

@methane methane changed the base branch from master to 3.6 February 11, 2017 09:19
@codecov
Copy link

codecov bot commented Feb 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (3.6@2d0c228). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             3.6      #25   +/-   ##
======================================
  Coverage       ?   82.37%           
======================================
  Files          ?     1427           
  Lines          ?   350948           
  Branches       ?        0           
======================================
  Hits           ?   289094           
  Misses         ?    61854           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0c228...1952adf. Read the comment docs.

@berkerpeksag
Copy link
Member

I think the plan is to make sure everything works fine on master first and then backport .travis.yml to maintenance branches.

@methane
Copy link
Member Author

methane commented Feb 11, 2017

I'm sorry. What remains?

@methane
Copy link
Member Author

methane commented Feb 11, 2017

Should I close this PR for now?

@berkerpeksag
Copy link
Member

No need to close, but I'd wait for a couple days before merging these backports. See also http://bugs.python.org/issue29529.

@brettcannon brettcannon changed the title Add .travis.yml to 3.6 branch bpo-29529: Add .travis.yml to 3.6 branch Feb 11, 2017
@brettcannon
Copy link
Member

So @berkerpeksag is right that I didn't backport any of this on purpose because I knew things like python/core-workflow#19 would come up when people more experienced than me in Travis usage would make suggestions. (I was also waiting for the IRC encryption stuff to land but I believe 4538ddc covers that specific issue.)

@brettcannon
Copy link
Member

GH-74 has proposed changes to .travis.yml.

@methane
Copy link
Member Author

methane commented Feb 14, 2017

while GH-74 looks nice, I feel inconvenience for lack of travis check for 3.6 branch...

@berkerpeksag
Copy link
Member

#74 has been merged. Please give me a couple days so I can make sure that I didn't cause any regression in our Travis configuration.

methane and others added 3 commits February 14, 2017 20:22
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
@methane
Copy link
Member Author

methane commented Feb 14, 2017

I did cherry pick changes in master.
Feel free to push merge button when you feels good.

@berkerpeksag
Copy link
Member

Here's another one to be cherry-picked @methane :) c33ee85

@methane methane changed the title bpo-29529: Add .travis.yml to 3.6 branch [backport to 3.6] bpo-29529: Add .travis.yml to 3.6 branch Feb 14, 2017
@ncoghlan ncoghlan merged commit 3337d33 into python:3.6 Feb 19, 2017
@ncoghlan
Copy link
Contributor

Going ahead and merging this so we actually get CI on the maintenance branches :)

jaraco pushed a commit that referenced this pull request Dec 2, 2022
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
This is one of the two approved incoming PSF licenses.

Closes python#23
Fidget-Spinner referenced this pull request in pylbbv/pylbbv May 27, 2023
Perf+Feat: Removed unnecessary declarations in type propagator and type annotated more bytecode
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants