gh-86013: Update "Install launcher for all users" win installer option #24570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Install launcher for all users" option on the front page of the installer now reads "Install py.exe launcher for all users".
eryksun
reviewed
Feb 19, 2021
| @@ -86,7 +86,7 @@ Select Customize to review current options.</String> | |||
| <String Id="ShortPrependPathLabel">Add &Python [ShortVersion] to PATH</String> | |||
| <String Id="InstallAllUsersLabel">Install for &all users</String> | |||
| <String Id="InstallLauncherAllUsersLabel">for &all users (requires elevation)</String> | |||
| <String Id="ShortInstallLauncherAllUsersLabel">Install &launcher for all users (recommended)</String> | |||
| <String Id="ShortInstallLauncherAllUsersLabel">Install py.exe &launcher for all users (recommended)</String> | |||
There was a problem hiding this comment.
Bikeshedding: When customizing the installation, on the optional features page, it's called "py launcher", so I'd prefer it without the ".exe" extension, unless Include_launcherLabel is changed to "py.ex &launcher".
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
erlend-aasland
changed the title
|
Is this still needed, @zooba? |
|
No, looks like we made an equivalent change at another time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Install launcher for all users" option on the front page of
the installer now reads "Install py.exe launcher for all users".
https://bugs.python.org/issue41847