Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "install launcher for all users" installer option #86013

Closed
zooba opened this issue Sep 23, 2020 · 4 comments
Closed

Update "install launcher for all users" installer option #86013

zooba opened this issue Sep 23, 2020 · 4 comments
Labels
3.13 bugs and security fixes OS-windows type-feature A feature request or enhancement

Comments

@zooba
Copy link
Member

zooba commented Sep 23, 2020

BPO 41847
Nosy @pfmoore, @tjguk, @zware, @eryksun, @zooba, @ZackerySpytz
PRs
  • gh-86013: Update "Install launcher for all users" win installer option #24570
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-09-23.22:45:27.100>
    labels = ['type-feature', '3.10', 'OS-windows']
    title = 'Update "install launcher for all users" installer option'
    updated_at = <Date 2021-02-19.04:06:54.076>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2021-02-19.04:06:54.076>
    actor = 'eryksun'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Windows']
    creation = <Date 2020-09-23.22:45:27.100>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41847
    keywords = ['patch']
    message_count = 3.0
    messages = ['377430', '377432', '387281']
    nosy_count = 6.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'eryksun', 'steve.dower', 'ZackerySpytz']
    pr_nums = ['24570']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue41847'
    versions = ['Python 3.10']

    @zooba
    Copy link
    Member Author

    zooba commented Sep 23, 2020

    The "Install launcher for all users" option on the front page of the installer should be updated to read "Install py.exe launcher for all users" to reduce confusion.

    However, we should also consider disabling this by default, so that the normal settings do not require admin privileges to install.

    The reason we started with it enabled by default is because we had to stomp on the 3.4 and earlier py.exe, since there was no other way to make sure it wasn't an issue. That problem still remains, which likely means that if we detect an all-users launcher from a previous version we need to keep the option enabled, but at least for clean installs of 3.10 we can avoid the need for admin completely.

    @zooba zooba added 3.10 only security fixes OS-windows type-feature A feature request or enhancement labels Sep 23, 2020
    @zooba
    Copy link
    Member Author

    zooba commented Sep 23, 2020

    Follow up thought: we could switch out the front page checkbox for "Upgrade existing py.exe launcher (recommended)" when we detect an existing per-machine install, and hide it entirely if we don't detect it. So at least non-admin users have an easy way to bypass the admin requirement.

    @eryksun
    Copy link
    Contributor

    eryksun commented Feb 19, 2021

    but at least for clean installs of 3.10 we can avoid the need
    for admin completely

    Except updating PATHEXT always requires admin access. I do this manually by setting a user PATHEXT variable with %PATHEXT% as the first item and append the extensions that I need. This is okay because the system environment gets populated before the user environment, and a system environment that doesn't define PATHEXT is improperly configured. I don't know whether WiX/MSI can support this, but it's probably not worth the hassle and potential problems.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland erlend-aasland added 3.13 bugs and security fixes and removed 3.10 only security fixes labels Jan 5, 2024
    @erlend-aasland
    Copy link
    Contributor

    @erlend-aasland erlend-aasland closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.13 bugs and security fixes OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants