Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "stale" GitHub Action #21247

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Adding "stale" GitHub Action #21247

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7e77bb
Adding "stale" GitHub Action
Mariatta Jun 30, 2020
1f0341a
Update .github/workflows/stale.yml
Mariatta Jul 2, 2020
57ac125
Update .github/workflows/stale.yml
Mariatta Jul 2, 2020
2a348c4
Update .github/workflows/stale.yml
Mariatta Jul 2, 2020
baa6909
Set days-before-close to -1
Mariatta Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Mark stale pull requests

on:
schedule:
- cron: "0 0 * * *"

jobs:
stale:

runs-on: ubuntu-latest

steps:
- uses: actions/[email protected]
Mariatta marked this conversation as resolved.
Show resolved Hide resolved
with:
repo-token: ${{ secrets.BEDEVERE_GH_TOKEN }}
Mariatta marked this conversation as resolved.
Show resolved Hide resolved
stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days'
stale-pr-label: 'stale-pr'
Mariatta marked this conversation as resolved.
Show resolved Hide resolved
days-before-stale: 30
days-before-close: 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we prepared to close out stale PRs? I think this would require a much wider discussion as that's a change in development approach.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a prior discussion in python/core-workflow#93 but we have never reached decision. I can ask in Discourse.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked in https://discuss.python.org/t/decision-needed-should-we-close-stale-prs-and-how-many-lapsed-days-are-prs-considered-stale/4637 but I've made the rest of the suggested change.