-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "stale" GitHub Action #21247
Adding "stale" GitHub Action #21247
Conversation
Added the "stale" GitHub action to the CPython repo. PR's older than 30 days will be labeld as stale using the "stale-pr" label. If needed, it can be configured to more than 30 days. I've added bedevere-bot's GitHub token to the repo's secret settings as ``BEDEVERE_GH_TOKEN`` Closes python/core-workflow#372
.github/workflows/stale.yml
Outdated
stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days' | ||
stale-pr-label: 'stale-pr' | ||
days-before-stale: 30 | ||
days-before-close: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we prepared to close out stale PRs? I think this would require a much wider discussion as that's a change in development approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a prior discussion in python/core-workflow#93 but we have never reached decision. I can ask in Discourse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked in https://discuss.python.org/t/decision-needed-should-we-close-stale-prs-and-how-many-lapsed-days-are-prs-considered-stale/4637 but I've made the rest of the suggested change.
When you're done making the requested changes, leave the comment: |
Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Brett Cannon <[email protected]>
I have made the requested changes; please review again |
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the structure of the PR while the discussion of whether this should gets merged happens.
I've set the |
I don't know why azure pipelines CI is failing 🙃 and I couldn't figure out how to restart it. |
Adding "stale" GitHub Action Added the "stale" GitHub action to the CPython repo. PR's older than 30 days will be labeled as stale using the "stale-pr" label. Closes python/core-workflow#372 Co-authored-by: Brett Cannon <[email protected]>
Added the "stale" GitHub action to the CPython repo.
PR's older than 30 days will be labeld as stale using the "stale-pr" label.
If needed, it can be configured to more than 30 days.
I've added bedevere-bot's GitHub token to the repo's secret settings as
BEDEVERE_GH_TOKEN
https://github.com/actions/stale
Closes python/core-workflow#372