Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename README to README.rst and enhance formatting #2

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Rename README to README.rst and enhance formatting #2

merged 1 commit into from
Feb 11, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 10, 2017

README.rst is recognized by GitHub which will render the README as reStructured text (nice!), instead of plain text.

Example with my tiny project https://github.com/haypo/perf which has a README.rst file.

@vstinner
Copy link
Member Author

I checked if the "README" file was referenced directly somewhere: I only found Makefile.pre.in.

@zware
Copy link
Member

zware commented Feb 10, 2017

This could use some additional formatting enhancement, such as changing things like "./configure --help" to

``./configure --help``

Also, links can be turned into linked text rather than written out URLs.

@vstinner
Copy link
Member Author

@zware: I hesitated, but ok: I made these changes.

I also added a link to the python-ideas mailing list, and I updated the Release Schedule to the Python 3.7 PEP.

@refi64 refi64 mentioned this pull request Feb 10, 2017
README.rst Outdated Show resolved Hide resolved
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things, but mostly looks good!

Python executable in a place that is not normally on your PATH, you may want to
set up a symlink in /usr/local/bin.
set up a symlink in ``/usr/local/bin``.

On Windows, see PCbuild/readme.txt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such change are out of the scope of my initial change. I suggest to make more enhancements in a second change.

primary version, you would execute "make install" in your 3.7 build directory
and "make altinstall" in the others.
primary version, you would execute ``make install`` in your 3.7 build directory
and ``make altinstall`` in the others.


Issue Tracker and Mailing List
------------------------------

We're soliciting bug reports about all aspects of the language. Fixes are also
welcome, preferably in unified diff format. Please use the issue tracker:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole section can use updating:

Bug reports are welcome!  You can use the `issue tracker
<https://bugs.python.org>`_ to report bugs, and/or submit pull requests `on
Github <https://github.com/python/cpython>`_.

You can also follow development discussion on the `python-dev mailing list
<https://mail.python.org/mailman/listinfo/python-dev/>`_.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

README.rst Outdated Show resolved Hide resolved
Update also the Release Schedule to Python 3.7.
@codecov
Copy link

codecov bot commented Feb 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@4538ddc). Click here to learn what that means.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   82.37%           
=========================================
  Files             ?     1427           
  Lines             ?   350948           
  Branches          ?        0           
=========================================
  Hits              ?   289087           
  Misses            ?    61861           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4538ddc...a44be7d. Read the comment docs.

@vstinner
Copy link
Member Author

Ok, it seems like Eric and Zach want :pep:537: so I made this change.

But I prefer to restrict this change to converting README to README.rst and fix/enhance reST syntax. If you want to more general update/enhancements of README, I suggest to work on a new change based on mine.

Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough :)

@vstinner vstinner merged commit d783b01 into python:master Feb 11, 2017
@vstinner vstinner deleted the README branch February 11, 2017 01:21
@vstinner
Copy link
Member Author

And the winner is .... http://www.python.org/dev/peps/pep-0537 => HTTP link. But since each change now requires a PR, I'm not interested to write a PR just to replace HTTP with HTTPS :-p

@zware
Copy link
Member

zware commented Feb 11, 2017

I'd recommend to report that as a bug to Github :). It is at least redirected to https automatically.

@Mariatta
Copy link
Member

Do we want to backport this to 3.5 and 2.7?

@vstinner
Copy link
Member Author

vstinner commented Feb 25, 2017 via email

@Mariatta
Copy link
Member

Thanks @Haypo . I saw the messages in http://bugs.python.org/issue29579. Seems like we won't be backporting readme changes to 3.5 and 2.7.
I'll remove the labels.

zooba referenced this pull request in zooba/cpython May 1, 2018
native-api pushed a commit to native-api/cpython that referenced this pull request Jun 5, 2018
@miss-islington
Copy link
Contributor

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @Mariatta, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e699b1b7c60b648693cff9a370ab50bff373baeb 3.12

@mariatta-bot
Copy link

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@mariatta-bot
Copy link

Sorry, @Mariatta, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e699b1b7c60b648693cff9a370ab50bff373baeb 3.12

bytemarx added a commit to bytemarx/cpython that referenced this pull request Dec 10, 2023
Hijacked the interpreter state to get my boys on the inside. Currently,
there doesn't seem to be an officially supported way to get a piece of
pre-initialized per-interpreter memory over to an embedded module (more
specifically, the embedded module's functions).
For example:
    [init'd mem python#1] ----> [subinterp python#1] ----> {module fn call}
    [init'd mem python#2] ----> [subinterp python#2] ----> {module fn call}
{module fn call} has a single implementation with access to its module
state via \`PyModule_GetState\`. The initialization of a subinterpreter
populates a custom entry for the pre-initialized memory in its interpreter
state. On initialization of the embedded module (\`Py_mod_exec\`), the
module state is populated with the custom entry
(\`PyThreadState_Get()->interp\`). The module function now has access to
the pre-initialized memory via its module state.
bytemarx added a commit to bytemarx/cpython that referenced this pull request Dec 10, 2023
Hijacked the interpreter state to get my boys on the inside. Currently,
there doesn't seem to be an officially supported way to get a piece of
pre-initialized per-interpreter memory over to an embedded module (more
specifically, the embedded module's functions).
For example:
    [init'd mem python#1] ----> [subinterp python#1] ----> {module fn call}
    [init'd mem python#2] ----> [subinterp python#2] ----> {module fn call}
{module fn call} has a single implementation with access to its module
state via `PyModule_GetState`. The initialization of a subinterpreter
populates a custom entry for the pre-initialized memory in its interpreter
state. On initialization of the embedded module (`Py_mod_exec`), the
module state is populated with the custom entry
(`PyThreadState_Get()->interp`). The module function now has access to
the pre-initialized memory via its module state.
barneygale added a commit to barneygale/cpython that referenced this pull request Jan 8, 2024
barneygale added a commit to barneygale/cpython that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants