Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123990: Good bye WITH_FREELISTS macro #124358

Merged
merged 7 commits into from
Sep 24, 2024
Merged

gh-123990: Good bye WITH_FREELISTS macro #124358

merged 7 commits into from
Sep 24, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Sep 23, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 23, 2024
Closed
@corona10 corona10 marked this pull request as ready for review September 23, 2024 20:50
colesbury
colesbury approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments below, but otherwise LGTM

Misc/NEWS.d/next/Build/2024-09-23-11-27-25.gh-issue-123990.d6HrYC.rst Outdated
@@ -0,0 +1 @@
Remove ``WITH_FREELISTS`` macro and ``--with-freelists`` build configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the --without-freelists configuration that got removed, right?

(The --with-freelists configuration was the default)

Objects/floatobject.c
@@ -235,12 +235,10 @@ static void
float_dealloc(PyObject *op)
{
assert(PyFloat_Check(op));
#ifdef WITH_FREELISTS
if (PyFloat_CheckExact(op)) {
_PyFloat_ExactDealloc(op);
}
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can move the { up to the same line as the else now

@corona10 corona10 enabled auto-merge (squash) September 23, 2024 23:40
@corona10 corona10 merged commit ad7c778 into python:main Sep 24, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @colesbury