Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WITH_FREELISTS macro #123990

Closed
corona10 opened this issue Sep 12, 2024 · 0 comments
Closed

Remove WITH_FREELISTS macro #123990

corona10 opened this issue Sep 12, 2024 · 0 comments
Assignees
@corona10
Labels
3.14 new features, bugs and security fixes sprint

Comments

@corona10
Copy link
Member

corona10 commented Sep 12, 2024 •
edited by bedevere-app bot
Loading

As we discussed at https://discuss.python.org/t/should-we-remove-the-with-freelists-macro,
we just added this macro to test mimalloc's own feature without using our own free list implementation.
See: #89685

But since we already implemented per thread freelist at the #111968 for freethreading, we don't need this flag anymore.

I will remove this macro during this year's core sprint (only around two weeks left)
https://discuss.python.org/t/2024-core-dev-sprint-in-bellevue-wa-september-23-27/39227

cc @colesbury @vstinner @markshannon

Linked PRs
@corona10 corona10 self-assigned this Sep 12, 2024
@corona10 corona10 added the 3.14 new features, bugs and security fixes label Sep 12, 2024
corona10 added a commit to corona10/cpython that referenced this issue Sep 23, 2024
@corona10
pythongh-123990: Good bye WITH_FREELISTS macro
f174e55
@bedevere-app bedevere-app bot mentioned this issue Sep 23, 2024
Merged
corona10 added a commit that referenced this issue Sep 24, 2024
@corona10
gh-123990: Good bye WITH_FREELISTS macro (gh-124358)
ad7c778
@github-project-automation github-project-automation bot moved this from Todo to Done in Sprint 2024 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corona10 corona10

Labels
3.14 new features, bugs and security fixes sprint
Projects
Sprint 2024
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corona10