gh-117398: Use the correct module loader for iOS in datetime CAPI test. #120477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 03293ac 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks for fixing this. Sorry I didn't catch it yesterday! FWIW, I like your solution taking advantage of the f-string. 😄 |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…PI test. (python#120477) Use the correct loader for iOS.
|
GH-121561 is a backport of this pull request to the 3.13 branch. |
freakboy3742
pushed a commit
that referenced
this pull request
Jul 10, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…PI test. (python#120477) Use the correct loader for iOS.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…PI test. (python#120477) Use the correct loader for iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119604 added a CAPI test for subinterpreters in the datetime tests; however, the test uses the ExtensionFileLoader to load
_testcapi. iOS requires the use of the AppleFrameworkLoader.The buildbot validation will fail because of #120476; however, with this PR,
test_datetimeno longer fails.