gh-113336: Remove the 'version' directive from Argument Clinic #113341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has not been in use in the CPython code base, and the 'version' variable has never been bumped.
AlexWaygood
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
LGTM, though I'm a tiny bit worried about Chesterton's fence here. I'd love it if @serhiy-storchaka could also take a look!
serhiy-storchaka
approved these changes
Dec 21, 2023
|
Thanks for the reviews, Alex and Serhiy. |
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…ython#113341) The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has not been in use in the CPython code base, and the 'version' variable has never been bumped.
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…ython#113341) The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has not been in use in the CPython code base, and the 'version' variable has never been bumped.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ython#113341) The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has not been in use in the CPython code base, and the 'version' variable has never been bumped.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ython#113341) The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has not been in use in the CPython code base, and the 'version' variable has never been bumped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'version' directive was introduced with gh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.