Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument Clinic: remove the 'version' directive #113336

Closed
erlend-aasland opened this issue Dec 20, 2023 · 0 comments
Closed

Argument Clinic: remove the 'version' directive #113336

erlend-aasland opened this issue Dec 20, 2023 · 0 comments
Labels
topic-argument-clinic type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Dec 20, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

The version directive was added in #63929 (Nov 2013), to make it possible for a programmer to require a specific version of Argument Clinic. However, since the "version number" has been hard-coded to "1" since Nov 2013, the version directive has not been used in the CPython code base, and since Argument Clinic is an internal tool, I suggest we remove this feature.

Linked PRs
@erlend-aasland erlend-aasland added type-feature A feature request or enhancement topic-argument-clinic labels Dec 20, 2023
@erlend-aasland erlend-aasland mentioned this issue Dec 20, 2023
Closed
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Dec 20, 2023
@erlend-aasland
pythongh-113336: Remove the 'version' directive from Argument Clinic
413e64c 
The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
@bedevere-app bedevere-app bot mentioned this issue Dec 20, 2023
Merged
erlend-aasland added a commit that referenced this issue Dec 21, 2023
@erlend-aasland
gh-113336: Remove the 'version' directive from Argument Clinic (#113341)
fae096c 
The 'version' directive was introduced with gh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
ryan-duve pushed a commit to ryan-duve/cpython that referenced this issue Dec 26, 2023
@erlend-aasland @ryan-duve
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
8c989c8 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
kulikjak pushed a commit to kulikjak/cpython that referenced this issue Jan 22, 2024
@erlend-aasland @kulikjak
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
bcd732b 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@erlend-aasland @aisk
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
8c59ec2 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@erlend-aasland @Glyphack
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
88f4f54 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-argument-clinic type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erlend-aasland