-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-104090: Fix unittest collectedDurations resources leak #106795
gh-104090: Fix unittest collectedDurations resources leak #106795
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
cdbe1c4
to
8cd162f
Compare
I think it might be better to split this into two PRs (attached to the same issue), one for the unittest fix and the other for the resource tracker change. |
5585599
to
509636a
Compare
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Done Second PR: #106807 |
CC unittest maintainers. @gpshead @ezio-melotti See issue for motivation. |
@giampaolo addDuration was added in 3.12. Should this be backported as a bugfix? |
…_concurrent_futures
Is this new entry necessary?
+1 from me |
🤖 New build scheduled with the buildbot fleet by @sunmy2019 for commit d493239 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Misc/NEWS.d/next/Tests/2023-07-16-02-57-08.gh-issue-104090.cKtK7g.rst
Outdated
Show resolved
Hide resolved
@iritkatriel wrote:
Hi! Yes, I think it should be backported. |
Thanks @bityob for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-106888 is a backport of this pull request to the 3.12 branch. |
…onGH-106795) (cherry picked from commit 70b961e) Co-authored-by: Yonatan Bitton <[email protected]>
Thanks @bityob for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…onGH-106795) (cherry picked from commit 70b961e) Co-authored-by: Yonatan Bitton <[email protected]>
thanks for figuring this out! |
TestResult.addDuration
method to add only test repr string and not the test object itself, to avoid resources leak@iritkatriel