gh-104090: Fix unittest collectedDurations resources leak

python · Jul 16, 2023 · 509636a · 509636a
1 parent 83bd568
commit 509636a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Lib/unittest/result.py b/Lib/unittest/result.py
@@ -166,7 +166,8 @@ def addDuration(self, test, elapsed):
         """
         # support for a TextTestRunner using an old TestResult class
         if hasattr(self, "collectedDurations"):
-            self.collectedDurations.append((test, elapsed))
+            # Pass test repr and not the test object itself to avoid resources leak
+            self.collectedDurations.append((str(test), elapsed))
 
     def wasSuccessful(self):
         """Tells whether or not this result was a success."""