-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-103650: Fix perf maps address format #103651
Conversation
art049
commented
Apr 20, 2023
•
edited by arhadthedev
Loading
edited by arhadthedev
- Issue: perf maps address format #103650
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
6cb2f11
to
8af8b2b
Compare
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
ddc2b2d
to
5df35f0
Compare
db8707f
to
4e43459
Compare
4e43459
to
0ba49e2
Compare
I think that this should wait until Pablo verifies that it is indeed the implementation that should be changed. |
@art049 did you verify that the new output after this PR works the same with @terryjreedy since the relevant docs here are the external perf map specification, not the CPython docs, it seems clear that the implementation in CPython should match the specification. There is no option to change the specification, we don't own it. |
Yes, also there are existing tests checking this: cpython/Lib/test/test_perf_profiler.py Lines 304 to 327 in 0ba49e2
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 0ba49e2 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Running this PR with the buildbots as the perf stuff is not checked on regular CI. |
* main: (47 commits) pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188) pythonGH-104308: socket.getnameinfo should release the GIL (python#104307) pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311) pythongh-99113: A Per-Interpreter GIL! (pythongh-104210) pythonGH-104284: Fix documentation gettext build (python#104296) pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251) pythongh-104223: Fix issues with inheriting from buffer classes (python#104227) pythongh-99108: fix typo in Modules/Setup (python#104293) pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172) pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275) pythongh-102500: Remove mention of bytes shorthand (python#104281) pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256) pythongh-99108: Replace SHA3 implementation HACL* version (python#103597) pythongh-104273: Remove redundant len() calls in argparse function (python#104274) pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200) pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266) pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244) pythongh-103650: Fix perf maps address format (python#103651) pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243) ...