Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tkinter Tk args and Gnome Shell application name #57762

Closed
th9 mannequin opened this issue Dec 8, 2011 · 8 comments
Closed

Tkinter Tk args and Gnome Shell application name #57762

th9 mannequin opened this issue Dec 8, 2011 · 8 comments
Labels
3.7 (EOL) end of life 3.8 (EOL) end of life docs Documentation in the Doc dir topic-tkinter type-bug An unexpected behavior, bug, or error

Comments

@th9
Copy link
Mannequin

th9 mannequin commented Dec 8, 2011

BPO 13553
Nosy @terryjreedy, @serwy, @serhiy-storchaka
PRs
  • bpo-13553: Document tkinter.Tk args #4786
  • Files
  • tk_wm_test.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2011-12-08.01:12:08.669>
    labels = ['3.7', '3.8', 'type-bug', 'expert-tkinter', 'docs']
    title = 'Tkinter Tk args and Gnome Shell application name'
    updated_at = <Date 2018-02-02.22:13:29.485>
    user = 'https://bugs.python.org/th9'

    bugs.python.org fields:

    activity = <Date 2018-02-02.22:13:29.485>
    actor = 'terry.reedy'
    assignee = 'docs@python'
    closed = False
    closed_date = None
    closer = None
    components = ['Documentation', 'Tkinter']
    creation = <Date 2011-12-08.01:12:08.669>
    creator = 'th9'
    dependencies = []
    files = ['23875']
    hgrepos = []
    issue_num = 13553
    keywords = ['patch']
    message_count = 7.0
    messages = ['149013', '149768', '149980', '150055', '150070', '166948', '224883']
    nosy_count = 6.0
    nosy_names = ['terry.reedy', 'roger.serwy', 'docs@python', 'th9', 'zup', 'serhiy.storchaka']
    pr_nums = ['4786']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue13553'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    Linked PRs

    @th9
    Copy link
    Mannequin Author

    th9 mannequin commented Dec 8, 2011

    I want the app name to be displayed under the icon in Alt+Tab menu, but currently it only displays the className of the root, which by default is "Tk". So in Gnome3 all Tkinter apps show up as "Tk" in the panel and in the Alt+Tab menu.

    It is possible to override that to some extent by giving className attribute to Tk(), but I don't know what the side effects are and it doesn't preserve capitalization of the name - the first letter is capital, but all others are small. Moreover, default title of the window is taken from the className by making first letter small and leaving the rest as given, so at the end nothing is as intended.

    E.g., if I give calssName="APP", the app is called "App", but windows title is "aPP".

    There should be a way to give this information, but I don't see it exposed anywhere and it is not correctly inferred from args[0] either.

    Example program attached.

    @th9 th9 mannequin added topic-tkinter type-bug An unexpected behavior, bug, or error labels Dec 8, 2011
    @zup
    Copy link
    Mannequin

    zup mannequin commented Dec 18, 2011

    The link below suggests that the problem with method 'iconname'
    may be due to the method not working at the window manager level:

    http://www.pythonware.com/library/tkinter/introduction/x9905-icon-methods.htm

    summary:

    iconname

    iconname(newName=None), iconname(). Set (get) the icon name to use when this window is iconified. This method are ignored by some window managers (including Windows).

    @th9
    Copy link
    Mannequin Author

    th9 mannequin commented Dec 21, 2011

    Yes, I'm aware of the 'iconname' docs. In this case 'iconname' probably is not the right property to set, but I don't know which one should be.

    For GTK+ applications there is a special function for setting application name which should be shown to user and apparently Gnome 3 is using that.

    http://developer.gnome.org/glib/stable/glib-Miscellaneous-Utility-Functions.html#g-set-application-name

    I don't know how to achieve the same for Tkinter.

    @serwy
    Copy link
    Mannequin

    serwy mannequin commented Dec 22, 2011

    Does IDLE appear as "Tk" in Gnome3?

    @th9
    Copy link
    Mannequin Author

    th9 mannequin commented Dec 22, 2011

    No, it apears as "Toplevel".

    I'm not sure if the program.desktop file has something to do with that, but I didn't manage to get the application name from a desktop file to get used for Tkinter program. And I don't have any Tkinter or Tk app which would do what I'm trying to do.

    For example, Firefox shows up as "Mozilla Firefox", but I don't see any X property with that value for Firefox window.. it might be something Mutter is doing.

    Here is xprop for IDLE and Firefox:
    $ sleep 5; xprop
    XKLAVIER_STATE(INTEGER) = 0, 0
    WM_STATE(WM_STATE):
    window state: Normal
    icon window: 0x0
    _NET_FRAME_EXTENTS(CARDINAL) = 1, 1, 23, 2
    _NET_WM_DESKTOP(CARDINAL) = 0
    _NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
    _NET_WM_STATE(ATOM) =
    WM_NORMAL_HINTS(WM_SIZE_HINTS):
    program specified minimum size: 1 by 1
    WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW
    WM_HINTS(WM_HINTS):
    Client accepts input or input focus: True
    Initial state is Normal State.
    _NET_WM_ICON_NAME(UTF8_STRING) = "Python Shell"
    WM_ICON_NAME(STRING) = "Python Shell"
    _NET_WM_NAME(UTF8_STRING) = "Python Shell"
    WM_NAME(STRING) = "Python Shell"
    WM_CLASS(STRING) = "42772672", "Toplevel"

    $ sleep 5; xprop 
    XKLAVIER_STATE(INTEGER) = 0, 0
    WM_STATE(WM_STATE):
    		window state: Normal
    		icon window: 0x0
    _NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 24, 0
    _NET_WM_DESKTOP(CARDINAL) = 0
    _NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
    _NET_WM_STATE(ATOM) = _NET_WM_STATE_MAXIMIZED_HORZ, _NET_WM_STATE_MAXIMIZED_VERT
    WM_HINTS(WM_HINTS):
    		Client accepts input or input focus: True
    		Initial state is Normal State.
    		bitmap id # to use for icon: 0x1600094
    		bitmap id # of mask for icon: 0x1600095
    		window id # of group leader: 0x1600001
    _NET_STARTUP_ID(UTF8_STRING) = "gnome-shell-17731-RD-OC-firefox-10_TIME71936264"
    WM_WINDOW_ROLE(STRING) = "browser"
    XdndAware(ATOM) = BITMAP
    _MOTIF_DRAG_RECEIVER_INFO(_MOTIF_DRAG_RECEIVER_INFO) = 0x6c, 0x0, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x10, 0x0, 0x0, 0x0
    _NET_WM_ICON(CARDINAL) = 	Icon (16 x 16):
    	 ░   ░▒▒▒▒░     
    	 ▒▒░▒▒▒  ░▒▒▒   
    	░▒░▒▒░▒  ░░▒░▒  
    	░░░░░░▒▒▓░░▒░░▒ 
    	▒░░░░░▒▒▓░░▒░ ░░
    	▒░░░░░░▒░░░▒▒ ░░
    	▒░░░░░░▒░▒▒▒▒ ░▒
    	▒░░▒▒▒▒▓▒▒▒▒▒ ░▒
    	▒░░░▒▒▓▒▒▒▒▒▒ ░▒
    	░▒░░▒▒▒▒▒▒▓▓░░░░
    	 ▒▒░░▒▒▒▒▓▒░░░▒░
    	 ▒▒░░░░▒▒▒▒░░▒▒ 
    	  ▒▒░░░░░░░░░▒  
    	   ▒▒▒▒▒▒▒▒▒▒░  
    	    ▒▒▒▒▒▒▒▒░   
    	     ░░▒▒░░     
    Icon (32 x 32):
                ░▒▒▒▓▒▒▒░           
              ▒▒▒░     ░▒▒▒         
            ░▓▒░         ░▒▒░       
        ░  ▒▓▒░           ▒▒▒▒░     
       ▒▒░▒▓▒▒░░░░        ░▒▒░▒░    
       ▓▒▒▓▒▒▒▒▒▓░       ░░░▒▒ ▒▒   
       ▓▒░░░░░▒▒▒░     ░░░░▒░░░ ▒▒  
      ░▒░░░░░▒▒▓▒       ░░░░▓░  ░▒░ 
      ▒▒░▒▒▒▒▒▒▒▒░░░     ░░░▒▒  ░░▒ 
     ░▒░▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░▒▒▓░   ▒ 
     ▒▒░▒▒▒▒▒▒▒▒░ ░▒░░░░░░░▒▒▓▒   ▒░
     ▒▒▒▒▒▒▒▒▒▒░░▒▒▒░░░░▒▒▒▒▒▒▒░  ▒▒
     ▓░▒▒▒▒▒▒▒░░░▒░░░░▒▒▒▒▒▒▓░▒░  ▒▓
     ▓░▒▒▒▒▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▓▒    ▒▓
     ▓░▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒▒▒▒▓▓▓▓▒    ▒▓
    ░▓▒▒▒▒▒▒▓▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒ ░ ░▒▓
     ▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▒ ░ ░░▒
     ▒▒▒▒▒▒▒▒▒▒░░▒▒▒░░ ░▓▓▓▓▒░ ░░░░▒
     ░▒▒▒▒▒▒▒▒▒▒░░░░░▒▒▒▓▓▓▓░░░░░░▒░
      ▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓░░░░░░▒ 
      ▒▓▒▒▒▒▒▒░░▒▓▓▓▓▓▓▓▓▓▓▒░░░░░▒▒ 
      ░▓▓▓▒▒▒▒░░░▒▓▓▓▓▓▓▓▓▒░░░░░▒▓░ 
       ▒▓▓▓▒▒▒▒░░░░▒▓▓▓▓▒░░░░░▒▒▓▒  
        ▓▓▓▒▒▒▒▒▒░░░░░░░░░░░░░░░▒░  
        ░▓▓▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░▒░   
         ▒▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▒░░░░▒▒    
          ▒▓▓▓▓▒▒▒▒▒▒▒░░░░░▒▒▒▒     
          ░▒▓▓▓▓▒▒▒▒▒▒▒▒░░░▒▒▒░     
           ░▒▒▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒░░     
            ░░▒▒▒▓▓▓▓▓▓▒▒▒▒░░       
              ░░▒▒▒▒▒▒▒▒▒░░         
                                    
    
    Icon (48 x 48):
                      ░▒▒▓▓▓▓▓▒▒░                   
                   ░▒▓▓▒░░    ░░▒▓▒░                
                 ▒▓▓▒             ▒▓▓▒              
               ░▓▓▒░               ░░▒▓░            
              ▒▓▓▒░                ░░ ░▓▒           
        ░░  ░▓▓▓▒▒░░                ░▒  ▒▓░         
        ▒░ ░▓▓▓▒▒░░░░░░             ░░▒░ ░▒▒        
       ░░░░▓▓▓▓▒▒▒░▒▒▒░            ░░░▒▒░  ▒▒       
       ▒░▒▒▒▓▒▒▒▒▒▒▒▒░             ░░▒░░▒   ▒▒      
       ▒▒▒▒░░░░░░▒▒▒▒░          ░░░░░▒▒░ ░   ▒░     
       ▒▒▒░░▒▒▒░▒▒▒▒▒░          ░░░░░░▒▒     ░▒     
       ▒░░░▒▒▒▒▒▒▒▒▒▒░           ░░░░░░▒▒     ▒░    
       ▒░▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░         ░░░░▒▓░  ░ ░     
       ░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒      ░░░░░░▒▒▒   ░      
      ░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░▒░░░░░░░░░░▒▒▒▒▓          
      ░▒▒▒▒▒▒▒▒▒▒▒▒▒▒░   ░▒░░░░░░░░░░▒▒▒▒▓░         
     ░░▒▒▒▒▒▒▒▒▒▒▒▒░░   ▒▒▒░░░░░▒▒▒░░▒▒▒▒▓░     ░   
     ░░▒▒▒▒▒▒▒▒▒▒▒▒░░░░▒▒░░░░░░░▒▒▒▒▒▒▒▓▒▒▒░░   ░░  
     ░░▒▒▒▒▒▒▒▒▒▒▒░░░░▒▒░░░░░░▒▒▒▒▒▒▒▒▒▓▒ ▒ ░░  ░▒░ 
     ░▒▒▒▒▒▒▒▒▒▒░░░░░░▒░░░░░░▒▒▒▒▒▒▒▒▒▒▓▒   ░░  ░▒▒ 
     ░▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓    ░  ░▓▒ 
     ░▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓       ░▓▒ 
     ▒▒▒▒▒▒▒▒▒▒▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓   ░   ▒▒░ 
    ░▒▒▒▒▒▒▒▒▒▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓░  ░  ░▒░░ 
    ░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓░ ░░ ░░░░░ 
    ░▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░▒▒▒▒▒▒░░░░▒▒▓▓▓▓▓▓▒▒░  ░░░░░░  
     ▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░▒▒░░░░░  ▒▒▓▓▓▓▓▒░░  ░░░░░░  
     ░▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░▒▒▒░▒▓▓▓▓▓▓░░░ ░░░░░░░  
     ░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░▒▒▒▒▒▓▓▓▓▓▓▓▓▓░░░░░░░░░▒   
      ▒▒▓▒▒▒▒▒▒▒▒▒▒▒▓▓▒▒▒▒▒▒▓▓▓▓▓▓▓▓▓▓▒░░░░░░░░▒░   
      ░▒▓▒▒▒▒▒▒▒▒▒▒░▒▒▓▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░▒░   
       ▒▓▓▒▒▒▒▒▒▒░░░░▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒░░░░░░░░▒▒░   
       ▒▒▓▓▓▒▒▒▒▒▒░░░░░▒▒▓▓▓▓▓▓▓▓▓▓▒▒░░░░░░░░░▒▒    
        ▒▓▓▓▒▒▒▒▒▒▒░░░░░░▒▓▓▓▓▓▓▓▒░░░░░░░░░░░▒▓░    
        ▒▓▓▓▓▒▒▒▒▒▒▒▒░░░░░░▒▒▒▒▒░░░░░░░░░░░▒▒▒░     
         ▒▓▓▓▓▒▒▒▒▒▒▒▒▒░░░░░░░░░░▒▒░░░░░░░▒▒░░      
         ░▒▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░▒░░░░░░░░      
          ░▒▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░       
           ░▓▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░        
            ░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░         
             ░▒▒▓▓▓▓▒▒▒▒▒▒▒▒▒░░░░░░░░░▒▒▒▒          
             ░░▒▒▒▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░         
             ░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░▒▒▒▒░░          
              ░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░▒▒▒░░           
                ░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░            
                  ░░░░▒▒▒▒▒▒▒▒▒▒░░░░░               
                      ░░░░░░░░░░░                   
    

    _NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 23068819
    _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
    _NET_WM_USER_TIME_WINDOW(WINDOW): window id # 0x1600092
    WM_CLIENT_LEADER(WINDOW): window id # 0x1600001
    _NET_WM_PID(CARDINAL) = 24976
    WM_LOCALE_NAME(STRING) = "lv_LV.utf8"
    WM_CLIENT_MACHINE(STRING) = "RD-OC"
    WM_NORMAL_HINTS(WM_SIZE_HINTS):
    program specified minimum size: 0 by 0
    window gravity: NorthWest
    WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
    WM_CLASS(STRING) = "Navigator", "Firefox"
    WM_ICON_NAME(STRING) = "bpo-13553: Tkinter doesn't set proper application name - Python tracker - Mozilla Firefox"
    _NET_WM_ICON_NAME(UTF8_STRING) = "bpo-13553: Tkinter doesn't set proper application name - Python tracker - Mozilla Firefox"
    WM_NAME(STRING) = "bpo-13553: Tkinter doesn't set proper application name - Python tracker - Mozilla Firefox"
    _NET_WM_NAME(UTF8_STRING) = "bpo-13553: Tkinter doesn't set proper application name - Python tracker - Mozilla Firefox"

    @serwy
    Copy link
    Mannequin

    serwy mannequin commented Jul 31, 2012

    It looks like this code will set the title properly in the latest GNOME shell (3.4):

        from Tkinter import *
        app = Tk(className='App Name')
        app.title('App Title')
        app.mainloop()

    The documentation should be updated to explain the arguments to Tk().

    @serwy serwy mannequin changed the title Tkinter doesn't set proper application name Tkinter doesn't set proper application name in Gnome Shell Jul 31, 2012
    @terryjreedy
    Copy link
    Member

    The resolution of this issue should be to properly document the Tk class. The 3.4 docs currently say:

    "class tkinter.Tk(screenName=None, baseName=None, className='Tk', useTk=1)
    The Tk class is instantiated without arguments. This creates a toplevel widget of Tk which usually is the main window of an application. Each instance has its own associated Tcl interpreter."

    The signature is incomplete -- see below. The first sentence is wrong; there are arguments, they just all happen to have defaults. The next sentence should be something like "Return a toplevel Tk widget, which is usually the main window of an application."

    Tk.__doc__ is 'Toplevel widget of Tk which represents mostly the main window\n of an application. It has an associated Tcl interpreter.' This is probably ok.

    Tk.__init__ signature and Tk,init.__doc__ are

    __init__(self, screenName=None, baseName=None, className='Tk', useTk=1, sync=0, use=None)

    "Return a new Toplevel widget on screen SCREENNAME. A new Tcl interpreter will
    be created. BASENAME will be used for the identification of the profile file (see
    readprofile).
    It is constructed from sys.argv[0] without extensions if None is given. CLASSNAME
    is the name of the widget class."

    "Toplevel" should be "toplevel" as in : Tk is not a subclass of Toplevel. Rather Toplevel is similar to Tk but with the BaseWidget signature.

    The argument list needs to be completed and perhaps a bit more said about the one documented. Does 'screen' apply to anything other than X11? Could it be used on Windows to put the window on a secondary screen? Is Gnome the only user framework that uses classname?

    @terryjreedy terryjreedy added the docs Documentation in the Doc dir label Aug 5, 2014
    @terryjreedy terryjreedy changed the title Tkinter doesn't set proper application name in Gnome Shell Tkinter Tk args and Gnome Shell application name Aug 5, 2014
    @csabella csabella added the 3.7 (EOL) end of life label Dec 11, 2017
    @terryjreedy terryjreedy added the 3.8 (EOL) end of life label Feb 2, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @hauntsaninja
    Copy link
    Contributor

    hauntsaninja commented Oct 29, 2022

    Took a couple years, but #4786 almost completes this. The only thing missing I can tell from @terryjreedy's comment above is the docstring disambiguation of "Toplevel", PR for this here: #98837

    hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue Oct 29, 2022
    Mentioned as a desired change by terryjreedy on the corresponding issue,
    since Tk is not a subclass of Toplevel.
    hauntsaninja added a commit that referenced this issue Dec 22, 2022
    Mentioned as a desired change by terryjreedy on the corresponding issue,
    since Tk is not a subclass of Toplevel.
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 22, 2022
    Mentioned as a desired change by terryjreedy on the corresponding issue,
    since Tk is not a subclass of Toplevel.
    (cherry picked from commit ad23da0)
    
    Co-authored-by: Shantanu <[email protected]>
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 22, 2022
    Mentioned as a desired change by terryjreedy on the corresponding issue,
    since Tk is not a subclass of Toplevel.
    (cherry picked from commit ad23da0)
    
    Co-authored-by: Shantanu <[email protected]>
    miss-islington added a commit that referenced this issue Dec 22, 2022
    Mentioned as a desired change by terryjreedy on the corresponding issue,
    since Tk is not a subclass of Toplevel.
    (cherry picked from commit ad23da0)
    
    Co-authored-by: Shantanu <[email protected]>
    miss-islington added a commit that referenced this issue Dec 22, 2022
    Mentioned as a desired change by terryjreedy on the corresponding issue,
    since Tk is not a subclass of Toplevel.
    (cherry picked from commit ad23da0)
    
    Co-authored-by: Shantanu <[email protected]>
    iritkatriel added a commit to iritkatriel/cpython that referenced this issue Dec 28, 2022
    * Correct CVE-2020-10735 documentation (python#100306)
    
    * pythongh-94912: Added marker for non-standard coroutine function detection (python#99247)
    
    This introduces a new decorator `@inspect.markcoroutinefunction`,
    which, applied to a sync function, makes it appear async to
    `inspect.iscoroutinefunction()`.
    
    * Docs: Don't upload CI artifacts (python#100330)
    
    * pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803)
    
    Use a stack to implement os.walk iteratively instead of recursively to
    avoid hitting recursion limits on deeply nested trees.
    
    * pythongh-69929: re docs: Add more specific definition of \w (python#92015)
    
    Co-authored-by: Jelle Zijlstra <[email protected]>
    
    * pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927)
    
    Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
    Co-authored-by: Christian Heimes <[email protected]>
    Co-authored-by: Hugo van Kemenade <[email protected]>
    Fixes python#89051
    
    * pythongh-88211: Change lower-case and upper-case to match recommendations in imaplib docs (python#99625)
    
    * pythongh-100348: Fix ref cycle in `asyncio._SelectorSocketTransport` with `_read_ready_cb` (python#100349)
    
    * pythongh-99925: Fix inconsistency in `json.dumps()` error messages (pythonGH-99926)
    
    * Clarify that every thread has its own default context in contextvars (python#99246)
    
    * pythongh-99576: Fix cookiejar file that was not truncated for some classes (pythonGH-99616)
    
    Co-authored-by: Łukasz Langa <[email protected]>
    
    * pythongh-100188: Reduce misses in BINARY_SUBSCR_(LIST/TUPLE)_INT (python#100189)
    
    Don't specialize if the index is negative.
    
    * pythongh-99991: improve docs on str.encode and bytes.decode (python#100198)
    
    Co-authored-by: C.A.M. Gerlach <[email protected]>
    
    * pythongh-91081: Add note on WeakKeyDictionary behavior when deleting a replaced entry (python#91499)
    
    Co-authored-by: Pieter Eendebak <[email protected]>
    Co-authored-by: Jelle Zijlstra <[email protected]>
    
    * pythongh-85267: Improvements to inspect.signature __text_signature__ handling (python#98796)
    
    This makes a couple related changes to inspect.signature's behaviour
    when parsing a signature from `__text_signature__`.
    
    First, `inspect.signature` is documented as only raising ValueError or
    TypeError. However, in some cases, we could raise RuntimeError.  This PR
    changes that, thereby fixing python#83685.
    
    (Note that the new ValueErrors in RewriteSymbolics are caught and then
    reraised with a message)
    
    Second, `inspect.signature` could randomly drop parameters that it
    didn't understand (corresponding to `return None` in the `p` function).
    This is the core issue in python#85267. I think this is very surprising
    behaviour and it seems better to fail outright.
    
    Third, adding this new failure broke a couple tests. To fix them (and to
    e.g. allow `inspect.signature(select.epoll.register)` as in python#85267), I
    add constant folding of a couple binary operations to RewriteSymbolics.
    
    (There's some discussion of making signature expression evaluation
    arbitrary powerful in python#68155. I think that's out of scope. The
    additional constant folding here is pretty straightforward, useful, and
    not much of a slippery slope)
    
    Fourth, while python#85267 is incorrect about the cause of the issue, it turns
    out if you had consecutive newlines in __text_signature__, you'd get
    `tokenize.TokenError`.
    
    Finally, the `if name is invalid:` code path was dead, since
    `parse_name` never returned `invalid`.
    
    * pythonGH-100363: Speed up `asyncio.get_running_loop` (python#100364)
    
    * pythonGH-100133: fix `asyncio` subprocess losing `stderr` and `stdout` output (python#100154)
    
    * pythongh-100374: Fixed a bug in socket.getfqdn() (pythongh-100375)
    
    * pythongh-100129: Add tests for pickling all builtin types and functions (pythonGH-100142)
    
    * Remove unused variable from `dis._find_imports` (python#100396)
    
    * pythongh-78878: Fix crash when creating an instance of `_ctypes.CField` (python#14837)
    
    * pythonGH-69564: Clarify use of octal format of mode argument in help(os.chmod) (python#20621)
    
    Co-authored-by: Kumar Aditya <[email protected]>
    
    * pythonGH-99554: Pack location tables more effectively (pythonGH-99556)
    
    * Correct typo in typing.py (python#100423)
    
    In the docstring of `ParamSpec`, the name of `P = ParamSpec('P')` was
    mistakenly written as `'T'`.
    
    * pythongh-99761: Add `_PyLong_IsPositiveSingleDigit` function to check for single digit integers  (python#100064)
    
    * pythonGH-99770: Make the correct call specialization fail kind show up in the stats (pythonGH-99771)
    
    * pythongh-78997: fix bad rebase of moved test file (python#100424)
    
    * pythongh-100344: Add C implementation for `asyncio.current_task` (python#100345)
    
    Co-authored-by: pranavtbhat
    
    * pythonGH-99554: Trim trailing whitespace (pythonGH-100435)
    
    
    
    Automerge-Triggered-By: GH:brandtbucher
    
    * pythongh-85432: Harmonise parameter names between C and pure-Python implementations of `datetime.time.strftime`, `datetime.datetime.fromtimestamp` (python#99993)
    
    * pythongh-57762: fix misleading tkinter.Tk docstring (python#98837)
    
    Mentioned as a desired change by terryjreedy on the corresponding issue,
    since Tk is not a subclass of Toplevel.
    
    * pythongh-48496: Added example and link to faq for UnboundLocalError in reference (python#93068)
    
    * Fix typo in 3.12 What's New (python#100449)
    
    * pythongh-76963: PEP3118 itemsize of an empty ctypes array should not be 0 (pythonGH-5576)
    
    The itemsize returned in a memoryview of a ctypes array is now computed from the item type, instead of dividing the total size by the length and assuming that the length is not zero.
    
    * pythonGH-100459: fix copy-paste errors in specialization stats (pythonGH-100460)
    
    * pythongh-99110: Initialize `frame->previous` in init_frame to fix segmentation fault when accessing `frame.f_back` (python#100182)
    
    * pythongh-98712: Clarify "readonly bytes-like object" semantics in C arg-parsing docs (python#98710)
    
    * pythongh-92216: improve performance of `hasattr` for type objects (pythonGH-99979)
    
    * pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289)
    
    * Revert "pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289)" (python#100468)
    
    This reverts commit c3c7848.
    
    * pythongh-94155: Reduce hash collisions for code objects (python#100183)
    
    * Uses a better hashing algorithm to get better dispersion and remove commutativity.
    
    * Incorporates `co_firstlineno`, `Py_SIZE(co)`, and bytecode instructions.
    
    * This is now the entire set of criteria used in `code_richcompare`, except for `_PyCode_ConstantKey` (which would incorporate the types of `co_consts` rather than just their values).
    
    * pythongh-83076: 3.8x speed improvement in (Async)Mock instantiation (python#100252)
    
    * pythongh-99482: remove `jython` compatibility parts from stdlib and tests (python#99484)
    
    * bpo-40447: accept all path-like objects in compileall.compile_file (python#19883)
    
    Signed-off-by: Filipe Laíns <[email protected]>
    Signed-off-by: Filipe Laíns <[email protected]>
    Co-authored-by: Irit Katriel <[email protected]>
    Co-authored-by: Shantanu <[email protected]>
    
    * pythonGH-100425: Improve accuracy of builtin sum() for float inputs (pythonGH-100426)
    
    * pythongh-68320, pythongh-88302 - Allow for private `pathlib.Path` subclassing (pythonGH-31691)
    
    Users may wish to define subclasses of `pathlib.Path` to add or modify
    existing methods. Before this change, attempting to instantiate a subclass
    raised an exception like:
    
        AttributeError: type object 'PPath' has no attribute '_flavour'
    
    Previously the `_flavour` attribute was assigned as follows:
    
        PurePath._flavour        = xxx not set!! xxx
        PurePosixPath._flavour   = _PosixFlavour()
        PureWindowsPath._flavour = _WindowsFlavour()
    
    This change replaces it with a `_pathmod` attribute, set as follows:
    
        PurePath._pathmod        = os.path
        PurePosixPath._pathmod   = posixpath
        PureWindowsPath._pathmod = ntpath
    
    Functionality from `_PosixFlavour` and `_WindowsFlavour` is moved into
    `PurePath` as underscored-prefixed classmethods. Flavours are removed.
    
    Co-authored-by: Alex Waygood <[email protected]>
    Co-authored-by: Brett Cannon <[email protected]>
    Co-authored-by: Adam Turner <[email protected]>
    Co-authored-by: Eryk Sun <[email protected]>
    
    * pythongh-99947: Ensure unreported errors are chained for SystemError during import (pythonGH-99946)
    
    * Add "strict" to dotproduct(). Add docstring. Factor-out common code. (pythonGH-100480)
    
    * pythongh-94808: improve test coverage of number formatting (python#99472)
    
    * pythongh-100454: Start running SSL tests with OpenSSL 3.1.0-beta1 (python#100456)
    
    * pythongh-100268: Add is_integer method to int (python#100439)
    
    This improves the lives of type annotation users of `float` - which type checkers implicitly treat as `int|float` because that is what most code actually wants. Before this change a `.is_integer()` method could not be assumed to exist on things annotated as `: float` due to the method not existing on both types.
    
    * pythongh-77771: Add enterabs example in sched (python#92716)
    
    Co-authored-by: Shantanu <[email protected]>
    
    * pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871)
    
    Co-authored-by: Guido van Rossum <[email protected]>
    
    * pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871)
    
    Co-authored-by: Guido van Rossum <[email protected]>
    
    * Misc Itertools recipe tweaks (pythonGH-100493)
    
    * pythongh-100357: Convert several functions in `bltinsmodule` to AC (python#100358)
    
    * Remove wrong comment about `repr` in `test_unicode` (python#100495)
    
    * pythongh-99908: Tutorial: Modernize the 'data-record class' example (python#100499)
    
    Co-authored-by: Alex Waygood <[email protected]>
    
    * pythongh-100474: Fix handling of dirs named index.html in http.server (pythonGH-100475)
    
    
    
    If you had a directory called index.html or index.htm within a directory, it would cause http.server to return a 404 Not Found error instead of the directory listing. This came about due to not checking that the index was a regular file.
    
    I have also added a test case for this situation.
    
    Automerge-Triggered-By: GH:merwok
    
    * pythongh-100287: Fix unittest.mock.seal with AsyncMock (python#100496)
    
    * pythongh-99535: Add test for inheritance of annotations and update documentation (python#99990)
    
    * pythongh-100428: Make float documentation more accurate (python#100437)
    
    Previously, the grammar did not accept `float("10")`.
    Also implement mdickinson's suggestion of removing the indirection.
    
    * [Minor PR] Quotes in documentation changed into code blocks (python#99536)
    
    Minor formatting fix in documentation
    
    Co-authored-by: Shantanu <[email protected]>
    
    * pythongh-100472: Fix docs claim that compileall parameters could be bytes (python#100473)
    
    * pythongh-100519: simplification to `eff_request_host` in cookiejar.py (python#99588)
    
    `IPV4_RE` includes a `.`, and the `.find(".") == -1` included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern `in` syntax to make it clear what the check is doing here. The simplified implementation more clearly matches the wording in RFC 2965.
    
    Co-authored-by: hauntsaninja <[email protected]>
    
    * pythongh-99308: Clarify re docs for byte pattern group names (python#99311)
    
    * pythongh-92446: Improve argparse choices docs; revert bad change to lzma docs (python#94627)
    
    Based on the definition of the collections.abc classes, it is more accurate to use "sequence" instead of "container" when describing argparse choices.
    
    A previous attempt at fixing this in python#92450 was mistaken; this PR reverts that change.
    
    Co-authored-by: Shantanu <[email protected]>
    
    * Fix name of removed `inspect.Signature.from_builtin` method in 3.11.0a2 changelog (python#100525)
    
    * pythongh-100520: Fix `rst` markup in `configparser`  docstrings (python#100524)
    
    * pythongh-99509: Add `__class_getitem__` to `multiprocessing.queues.Queue` (python#99511)
    
    * pythongh-94603: micro optimize list.pop (pythongh-94604)
    
    * Remove `NoneType` redefinition from `clinic.py` (python#100551)
    
    * pythongh-100553: Improve accuracy of sqlite3.Row iter test (python#100555)
    
    * pythonGH-98831: Modernize a ton of simpler instructions (python#100545)
    
    * load_const and load_fast aren't families for now
    * Don't decref unmoved names
    * Modernize GET_ANEXT
    * Modernize GET_AWAITABLE
    * Modernize ASYNC_GEN_WRAP
    * Modernize YIELD_VALUE
    * Modernize POP_EXCEPT (in more than one way)
    * Modernize PREP_RERAISE_STAR
    * Modernize LOAD_ASSERTION_ERROR
    * Modernize LOAD_BUILD_CLASS
    * Modernize STORE_NAME
    * Modernize LOAD_NAME
    * Modernize LOAD_CLASSDEREF
    * Modernize LOAD_DEREF
    * Modernize STORE_DEREF
    * Modernize COPY_FREE_VARS (mark it as done)
    * Modernize LIST_TO_TUPLE
    * Modernize LIST_EXTEND
    * Modernize SET_UPDATE
    * Modernize SETUP_ANNOTATIONS
    * Modernize DICT_UPDATE
    * Modernize DICT_MERGE
    * Modernize MAP_ADD
    * Modernize IS_OP
    * Modernize CONTAINS_OP
    * Modernize CHECK_EXC_MATCH
    * Modernize IMPORT_NAME
    * Modernize IMPORT_STAR
    * Modernize IMPORT_FROM
    * Modernize JUMP_FORWARD (mark it as done)
    * Modernize JUMP_BACKWARD (mark it as done)
    
    Signed-off-by: Filipe Laíns <[email protected]>
    Signed-off-by: Filipe Laíns <[email protected]>
    Co-authored-by: Jeremy Paige <[email protected]>
    Co-authored-by: Carlton Gibson <[email protected]>
    Co-authored-by: Hugo van Kemenade <[email protected]>
    Co-authored-by: Jon Burdo <[email protected]>
    Co-authored-by: Stanley <[email protected]>
    Co-authored-by: Jelle Zijlstra <[email protected]>
    Co-authored-by: Thomas Grainger <[email protected]>
    Co-authored-by: Brad Wolfe <[email protected]>
    Co-authored-by: Richard Kojedzinszky <[email protected]>
    Co-authored-by: František Nesveda <[email protected]>
    Co-authored-by: Pablo Galindo Salgado <[email protected]>
    Co-authored-by: Nikita Sobolev <[email protected]>
    Co-authored-by: Łukasz Langa <[email protected]>
    Co-authored-by: Dennis Sweeney <[email protected]>
    Co-authored-by: Bisola Olasehinde <[email protected]>
    Co-authored-by: C.A.M. Gerlach <[email protected]>
    Co-authored-by: Pieter Eendebak <[email protected]>
    Co-authored-by: Shantanu <[email protected]>
    Co-authored-by: Kumar Aditya <[email protected]>
    Co-authored-by: Dominic Socular <[email protected]>
    Co-authored-by: Serhiy Storchaka <[email protected]>
    Co-authored-by: Hai Shi <[email protected]>
    Co-authored-by: amaajemyfren <[email protected]>
    Co-authored-by: Brandt Bucher <[email protected]>
    Co-authored-by: david-why <[email protected]>
    Co-authored-by: Pieter Eendebak <[email protected]>
    Co-authored-by: penguin_wwy <[email protected]>
    Co-authored-by: Eli Schwartz <[email protected]>
    Co-authored-by: Itamar Ostricher <[email protected]>
    Co-authored-by: Alex Waygood <[email protected]>
    Co-authored-by: Eric Wieser <[email protected]>
    Co-authored-by: Irit Katriel <[email protected]>
    Co-authored-by: Bill Fisher <[email protected]>
    Co-authored-by: Petr Viktorin <[email protected]>
    Co-authored-by: Ken Jin <[email protected]>
    Co-authored-by: Carl Meyer <[email protected]>
    Co-authored-by: Filipe Laíns <[email protected]>
    Co-authored-by: Raymond Hettinger <[email protected]>
    Co-authored-by: Barney Gale <[email protected]>
    Co-authored-by: Brett Cannon <[email protected]>
    Co-authored-by: Adam Turner <[email protected]>
    Co-authored-by: Eryk Sun <[email protected]>
    Co-authored-by: Sebastian Berg <[email protected]>
    Co-authored-by: Illia Volochii <[email protected]>
    Co-authored-by: JosephSBoyle <[email protected]>
    Co-authored-by: James Frost <[email protected]>
    Co-authored-by: MonadChains <[email protected]>
    Co-authored-by: Bart Broere <[email protected]>
    Co-authored-by: Glyph <[email protected]>
    Co-authored-by: hauntsaninja <[email protected]>
    Co-authored-by: Ilya Kulakov <[email protected]>
    Co-authored-by: Guy Yagev <[email protected]>
    Co-authored-by: Jakub Kuczys <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 (EOL) end of life docs Documentation in the Doc dir topic-tkinter type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants