Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99908: Tutorial: Modernize the 'data-record class' example #100499

Merged
merged 4 commits into from
Dec 24, 2022
Merged

gh-99908: Tutorial: Modernize the 'data-record class' example #100499

merged 4 commits into from
Dec 24, 2022

Conversation

JosephSBoyle
Copy link
Contributor

@JosephSBoyle JosephSBoyle commented Dec 24, 2022 •
edited by bedevere-bot
Loading

Modernize an antiquated example of a 'record' class to use dataclasses.

@bedevere-bot bedevere-bot mentioned this pull request Dec 24, 2022
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 24, 2022
@JosephSBoyle
Copy link
Contributor Author

Hi @AlexWaygood, all checks are passing now:)

@AlexWaygood AlexWaygood self-assigned this Dec 24, 2022
@AlexWaygood AlexWaygood mentioned this pull request Dec 24, 2022
Closed
AlexWaygood
AlexWaygood reviewed Dec 24, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JosephSBoyle, looks good! A few thoughts:

Doc/tutorial/classes.rst Show resolved Hide resolved
Doc/tutorial/classes.rst Outdated Show resolved Hide resolved
Doc/tutorial/classes.rst Outdated Show resolved Hide resolved
@JosephSBoyle
Copy link
Contributor Author

Thanks for the review @AlexWaygood!

I believe I've resolved all of your threads.

AlexWaygood
AlexWaygood approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @JosephSBoyle!

@AlexWaygood AlexWaygood changed the title gh-99908 Modernize the 'data-record class' example in the classes documentation gh-99908: Tutorial: Modernize the 'data-record class' example Dec 24, 2022
@AlexWaygood AlexWaygood merged commit 00afa50 into python:main Dec 24, 2022
@AlexWaygood AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 24, 2022
@miss-islington
Copy link
Contributor

Thanks @JosephSBoyle for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @JosephSBoyle for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100500 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 24, 2022
@bedevere-bot
Copy link

GH-100501 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JosephSBoyle @miss-islington @bedevere-bot @AlexWaygood