-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path.rglob
-> documentation does not specify what pattern
is
#101112
Comments
The documentation for `rglob` did not mention what `pattern` actually is. Mentioning and linking to `fnmatch` makes this explicit, as the documentation for `fnmatch` both shows the syntax and some explanation.
The documentation for It should probably say "patterns are the same as for |
Thanks! I will update my current PR, and I will also fix the documentation for |
On a second thought, and after reading the documentation for
I think linking to @barneygale What do you think of adding a pattern syntax table (similar to the one for fnmatch) to |
I think that's an excellent idea. Perhaps something like:
|
The docs for |
The documentation for `rglob` did not mention what `pattern` actually is. Mentioning and linking to `fnmatch` makes this explicit, as the documentation for `fnmatch` both shows the syntax and some explanation.
Unlike previously stated, the patterns used for `Path.glob`, `Path.rglob` and `Path.match` does not behave like the ones for `fnmatch`. Remove the refernce to `fnmatch` and provide an overview of the available patterns.
Unlike previously stated, the patterns used for `Path.glob`, `Path.rglob` and `Path.match` do not behave like the ones for `fnmatch`. Remove the refernce to `fnmatch` and provide an overview of the available patterns.
Unlike previously stated, the patterns used for `Path.glob`, `Path.rglob` and `Path.match` do not behave like the ones for `fnmatch`. Remove the refernce to `fnmatch` and provide an overview of the available patterns.
Unlike previously stated, the patterns used for `Path.glob`, `Path.rglob` and `Path.match` do not behave like the ones for `fnmatch`. Remove the refernce to `fnmatch` and provide an overview of the available patterns. Co-authored-by: Barney Gale <[email protected]>
Provide an overview of available patterns for `Path.glob` and reference it from `Path.rglob` and `Path.match`. Co-authored-by: Barney Gale <[email protected]>
Explain the `match()` / `glob()` / `rglob()` pattern language in its own section. Move `rglob()` documentation under `glob()` and reduce duplicated text.
Explain the `full_match()` / `glob()` / `rglob()` pattern language in its own section. Move `rglob()` documentation under `glob()` and reduce duplicated text.
Sorted in the 3.13 docs. Can backport if folks are interested, but it'll need to be a little different due to the introduction of |
…on#114030) Explain the `full_match()` / `glob()` / `rglob()` pattern language in its own section. Move `rglob()` documentation under `glob()` and reduce duplicated text.
…on#114030) Explain the `full_match()` / `glob()` / `rglob()` pattern language in its own section. Move `rglob()` documentation under `glob()` and reduce duplicated text.
…on#114030) Explain the `full_match()` / `glob()` / `rglob()` pattern language in its own section. Move `rglob()` documentation under `glob()` and reduce duplicated text.
Documentation
Today I came across
Path.rglob
in our codebase.I went to https://docs.python.org/3/library/pathlib.html#pathlib.Path.rglob and tried to find out what
pattern
actually is. While the current documentation links toPath.glob()
, I would like to add a note similar you can find at https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob, ieWould a PR be welcome to add this kind of information?
Linked PRs
Path.glob
#101223The text was updated successfully, but these errors were encountered: