Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filtered warning after fixed dependency released #74

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Remove filtered warning after fixed dependency released #74

merged 3 commits into from
Oct 4, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 9, 2022

The certifi library has just been released with its deprecation warning fixed, we can remove this workaround:

We need to keep the gidgethub workaround, it's fixed but not yet released:

@Mariatta
Copy link
Member

Mariatta commented Oct 4, 2022

I'll cut a release of gidgethub today

@Mariatta Mariatta added the hacktoberfest-accepted Accepted for hacktoberfest label Oct 4, 2022
@Mariatta
Copy link
Member

Mariatta commented Oct 4, 2022

gidgethub has just been released, so I think it means we can remove both now.

@hugovk
Copy link
Member Author

hugovk commented Oct 4, 2022

Updated to remove the other one now! 🚀

@Mariatta Mariatta merged commit 2c1f6b9 into python:main Oct 4, 2022
@hugovk hugovk deleted the rm-filterwarning branch October 6, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @Mariatta @ezio-melotti