Fix deprecation warning on Python 3.11 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Turner <[email protected]>
webknjaz
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Aug 3, 2022
webknjaz
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Aug 3, 2022
Refs: * benoitc/gunicorn#2840 * certifi/python-certifi#199 (cherry picked from commit bddb77d)
webknjaz
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Aug 3, 2022
Refs: * benoitc/gunicorn#2840 * certifi/python-certifi#199 (cherry picked from commit bddb77d)
|
Thank you for picking this up ! |
10 tasks
|
Since 3.11 is now ABI stable, the ecosystem is starting to build/test against it. Any plans for a release here so we don't have to put in warning ignores everywhere? |
|
New release was just pushed, 2022.06.15.1. |
tsibley
added a commit
to tsibley/python-certifi
that referenced
this pull request
Sep 13, 2022
…n ≥3.11 Using importlib.resource's files() API on 3.9 and 3.10 causes a TypeError on 3.9 and a ValueError on 3.10 when running under a third-party meta path importer (like PyOxidizer's OxidizedImporter) that doesn't support the relatively-new API. This is because the full adapter layer (importlib.resources._adapters) for the older importlib resources API doesn't exist until Python 3.11. The older resources API is now used by 3.7–3.10, as it was prior to the certifi 2022.06.15.1 release. This codepath has existed in certifi since April 2020 (3fc8fec). An alternative to this change would be testing the actual importer in use at runtime (e.g. certifi.__loader__) for files() support, but that seemed more complex than reverting to the previous codepath here. Resolves: certifi#203 Related-to: certifi#199 Related-to: certifi#123
Lukasa
pushed a commit
that referenced
this pull request
Sep 13, 2022
…n ≥3.11 (#204) Using importlib.resource's files() API on 3.9 and 3.10 causes a TypeError on 3.9 and a ValueError on 3.10 when running under a third-party meta path importer (like PyOxidizer's OxidizedImporter) that doesn't support the relatively-new API. This is because the full adapter layer (importlib.resources._adapters) for the older importlib resources API doesn't exist until Python 3.11. The older resources API is now used by 3.7–3.10, as it was prior to the certifi 2022.06.15.1 release. This codepath has existed in certifi since April 2020 (3fc8fec). An alternative to this change would be testing the actual importer in use at runtime (e.g. certifi.__loader__) for files() support, but that seemed more complex than reverting to the previous codepath here. Resolves: #203 Related-to: #199 Related-to: #123
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192.
Replaces and closes #193.
This is @adamchainz' PR #193 with @AA-Turner's suggestions applied, plus adding a missing
wherefor 3.6 which is the same as the 3.7-3.8 block.Also bump GitHub Actions versions.