Address issue #216: rename the klass argument to create_protocol. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify documentation wording a bit. * Make the backwards-compatibility logic more explicit (and removable). * Move klass with legacy_recv, the other backwards-compatibility shim.
aaugustin
force-pushed
the
issue-216-remove-klass
branch
from
5c7f89b to
39cec14
Compare
|
Excellent! 👍 for using I suggested a few tweaks. If you're OK with them, please merge. Thanks! |
|
Thanks, Aymeric! |
This was referenced Jul 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #216.
One minor note: you'll notice in the signatures that I made the default value
Noneinstead of the default class. The reason is that this makes the API somewhat friendlier when it comes to composing functions, etc. For example, if an end user defines a wrapper function and wants the same default, they can get the same default by passingNone. They don't need to hard-code the default value in a second place. Secondarily, when it comes to deciding betweencreate_protocolandklass, this makes it easier to know which arguments were explicitly passed.