Address issue #116: make existing hook take place before the handshake #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2017
cjerdonek
changed the title
cjerdonek
force-pushed
the
issue-116-handshake-hook
branch
from
45ab1d9 to
e83b826
Compare
|
Rebased (still need to address coverage). |
cjerdonek
force-pushed
the
issue-116-handshake-hook
branch
from
b5b6ead to
1c8362f
Compare
|
Rebased, and brought coverage back to 100%. |
cjerdonek
force-pushed
the
issue-116-handshake-hook
branch
2 times, most recently
from
7e3e470 to
5515d26
Compare
|
Rebased. |
cjerdonek
force-pushed
the
issue-116-handshake-hook
branch
from
5515d26 to
02b5a29
Compare
|
Rebased after PR #236. |
cjerdonek
changed the title
aaugustin
added a commit
that referenced
this pull request
Aug 12, 2017
This replaces the get_response_status() API which never made it into a release (so there's no backwards incompatibility). Remove a test that depends on get_response_status() being called after check_request(). The extension point must be before check_request() so it can handle regular HTTP requests. Fix #116. Supersedes #202 #154, #137.
aaugustin
added a commit
that referenced
this pull request
Aug 20, 2017
This replaces the get_response_status() API which never made it into a release (so there's no backwards incompatibility). Remove a test that depends on get_response_status() being called after check_request(). The extension point must be before check_request() so it can handle regular HTTP requests. Fix #116. Supersedes #202 #154, #137.
aaugustin
added a commit
that referenced
this pull request
Aug 20, 2017
This replaces the get_response_status() API which never made it into a release (so there's no backwards incompatibility). Remove a test that depends on get_response_status() being called after check_request(). The extension point must be before check_request() so it can handle regular HTTP requests. Fix #116. Supersedes #202 #154, #137.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an illustration of what I proposed in this comment to add a "pre-handshake" hook. All of the tests still pass (at least on my machine with 3.6.1).
If this approach is acceptable, I could make needed documentation changes, etc, and add a test of using the hook.