-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_remote_address
fails
#1427
Comments
This is likely related to the implementation of socket.socketpair and/or socket.socket.getpeername on OpenIndiana. That's what I'm using for testing and how The documentation of Do you a concrete proposal that doesn't make the code or the tests more complex? |
For clarity: to me this is an OpenIndiana and/or Python issue; websockets isn't the right level to fix this. If there's an easy solution that adds no maintenance cost and helps you, of course I'll consider it. The onus of proposing it is on you, though, because you're the one who wants to run the tests on OpenIndiana (and I wish you didn't, as explained in #1426). |
Could you please suggest some simple test that would prove the problem is either in socket.socketpair and/or socket.socket.getpeername on OpenIndiana? I tried this:
But that's apparently not enough. Thank you. |
Try this:
I expect that you'll get This shows that the test isn't very good... I will think about it. |
Perhaps I should rewrite that test to use a real IP socket. |
Yes, exactly,
|
Thank you for confirming. Honestly this test doesn't test anything beyond the existence of a |
I mocked socket methods with platform-specific behavior to make the tests more robust. Hopefully that'll do the job on OpenIndiana. Please let me know if it doesn't. |
I just tested websockets 12.0 + b3c5195 and I can confirm that the issue is gone. Thank you! |
I'm packaging
websockets
for OpenIndiana and when I ran tests I found following failures:The text was updated successfully, but these errors were encountered: