Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of loops shouldn't break test suite on 3.8 #1081

Closed
mcepl opened this issue Oct 29, 2021 · 1 comment
Closed

Deprecation of loops shouldn't break test suite on 3.8 #1081

mcepl opened this issue Oct 29, 2021 · 1 comment

Comments

@mcepl
Copy link

mcepl commented Oct 29, 2021

When packaging 10.0 for openSUSE I got 183 failures in the test suite (yes :(). Many of them are like this (just picked one random):

[   52s] ======================================================================
[   52s] FAIL: test_server_create_protocol (tests.legacy.test_client_server.ClientServerTests)
[   52s] ----------------------------------------------------------------------
[   52s] Traceback (most recent call last):
[   52s]   File "/home/abuild/rpmbuild/BUILD/websockets-10.0/tests/legacy/test_client_server.py", line 126, in _decorate
[   52s]     with manager(self, *args, **kwargs):
[   52s]   File "/usr/lib64/python3.9/contextlib.py", line 119, in __enter__
[   52s]     return next(self.gen)
[   52s]   File "/home/abuild/rpmbuild/BUILD/websockets-10.0/tests/legacy/test_client_server.py", line 96, in temp_test_server
[   52s]     test.start_server(**kwargs)
[   52s]   File "/home/abuild/rpmbuild/BUILD/websockets-10.0/tests/legacy/test_client_server.py", line 232, in start_server
[   52s]     self.assertDeprecationWarnings(recorded_warnings, expected_warnings)
[   52s]   File "/home/abuild/rpmbuild/BUILD/websockets-10.0/tests/legacy/utils.py", line 79, in assertDeprecationWarnings
[   52s]     self.assertEqual(
[   52s] AssertionError: Items in the first set but not the second:
[   52s] 'The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.'
[   52s]

Full log of the build with all details on packages used and steps taken to achieve it.

It seems to me that in your understandable effort to deprecate old command you broke your whole test suite. Any ideas how to fix it?

@aaugustin
Copy link
Member

It seems to me that you jumped to the conclusion that I was dumb enough to break my own test suite a bit too fast :-)

This is a bug in Python 3.9.7. It doesn't affect websockets itself; it only causes the test suite to fail. Duplicate of #1051.

aaugustin added a commit that referenced this issue Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants