-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use javascript template literal in Popup #962
Use javascript template literal in Popup #962
Conversation
…literal # Conflicts: # CHANGES.txt
I checked it and normal content seems to look good. Only issue was trying to add a However, I went into the HTML and manually changed the CDN links and switched
The way the template compiles right now, Not sure if you saw the discussion on the |
Thanks for checking this. Im away right now and will look at the Vega stuff after the weekend. That needs to be fixed before merging this. About the |
👍 |
It's necessary for vega charts
The Vega and Vega Lite charts were broken because I removed the jQuery code. Worked fine for normal text, but broke the charts. I restored that and now it seems fine. This PR is now quite trivial, so I'll wait a bit and then go ahead and merge this. |
@jtbaker can you check if this works for you as well?