-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apostrophes create broken maps without warning or failure #850
Comments
You're right about the map breaking down if the popup text contains invalid html. A popup is expected to receive valid html. If not, you should enable html parsing:
But of course that's not what you're asking. You're saying there should be a warning if invalid html is passed to Popup without How can we detect invalid html? Without making it too complicated, so no external packages or headless browsing.
Another option would be to enable html parsing by default. That way a map will never break silently. It will change behavior for users who are providing html though. But they will see that their html is being parsed, and can figure out they need to set |
This has been fixed in #962. |
Please add a code sample or a nbviewer link, copy-pastable if possible
Problem description
When adding popups with an apostrophe in the text, the generated HTML breaks down, so the map is generated but it cannot be displayed. This could possibly lead to failures in other cases, but this is the one I've often encountered. I believe a warning is due.
The text was updated successfully, but these errors were encountered: