Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten fixed pyroma test #3882

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Tighten fixed pyroma test #3882

merged 1 commit into from
Jun 4, 2019

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 2, 2019

PR #3752 relaxed a Pyroma test because (#3752 (comment)):

Pyroma was failing because "Your package does not have license data". When there's a known Trove licence, licence can and should be omitted, according to pypa/packaging.python.org#492.

I've reported this to pyroma (regebro/pyroma#38) and relaxed our test in the meantime.

Pyroma has now fixed regebro/pyroma#38 and released it in version 2.5, which means Pillow again scores a 10.

Let's undo the workaround (also fixes the build eg. https://travis-ci.org/python-pillow/Pillow/builds/540460207).

@hugovk hugovk added the Testing label Jun 2, 2019
@olt olt mentioned this pull request Jun 4, 2019
Merged
@hugovk hugovk merged commit 14766f5 into python-pillow:master Jun 4, 2019
@hugovk hugovk deleted the revert-pyroma-workaround branch June 4, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't mark down when known Trove licence present +license omitted
1 participant
@hugovk