Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark down when known Trove licence present +license omitted #38

Closed
hugovk opened this issue Mar 26, 2019 · 1 comment · Fixed by python-pillow/Pillow#3882
Closed

Comments

@hugovk
Copy link
Collaborator

hugovk commented Mar 26, 2019

According to https://packaging.python.org/guides/distributing-packages-using-setuptools/#license:

The license argument doesn't have to indicate the license under
which your package is being released, although you may optionally do
so if you want. If you're using a standard, well-known license, then
your main indication can and should be via the classifiers
argument. Classifiers exist for all major open-source licenses.

The "license" argument is more typically used to indicate differences
from well-known licenses, or to include your own, unique license. As a
general rule, it's a good idea to use a standard, well-known license,
both to avoid confusion and because some organizations avoid software
whose license is unapproved.

This was added in pypa/packaging.python.org#492 to "indicate that this argument is meant for deviations from the Trove classifier, not instead of it".

Actual result

If a project has a known Trove licence and the license classifier, it gets 10/10.

If the redundant license is removed, it's marked down to 9/10.

Expected result

Instead, pyroma should give 10/10 if there's a known Trove licence and no license argument. It should be marked down if it has both.

If the Trove licence is something like License :: Other/Proprietary License, it should be 10/10 when there is a license explaining what is being used, and marked down when license is missing.

@regebro
Copy link
Owner

regebro commented May 31, 2019

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants