Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for content{Encoding,MediaType} to Draft 7+ #593

Closed
Julian opened this issue Aug 4, 2019 · 1 comment
Closed

Add support for content{Encoding,MediaType} to Draft 7+ #593

Julian opened this issue Aug 4, 2019 · 1 comment
Labels
Enhancement Some new desired functionality

Comments

@Julian
Copy link
Member

Julian commented Aug 4, 2019

http://json-schema.org/latest/json-schema-validation.html#rfc.section.8.3

This looks like it was made optional.

I guess it can be off-by-default like format, or, since it's at least finite (maybe?) on by default.

Will see later.
@Julian Julian added the Enhancement Some new desired functionality label Aug 4, 2019
Julian added a commit that referenced this issue Aug 4, 2019
@Julian
Enable then skip the tests from #593.
10bf443
@Julian Julian added the Needs Test Upstream Issues that need to have a test added to https://github.com/json-schema-org/JSON-Schema-Test-Suite label Sep 4, 2019
@Julian Julian removed the Needs Test Upstream Issues that need to have a test added to https://github.com/json-schema-org/JSON-Schema-Test-Suite label Oct 31, 2019
@ssbarnea ssbarnea mentioned this issue May 20, 2022
Closed
@Julian
Copy link
Member Author

Julian commented Aug 21, 2022

Only draft7 even allowed these to be treated as assertions it seems, so I think this can be WONTFIXed. If someone ever decides to create a parallel assertion vocabulary for these it can be supported externally.

@Julian Julian closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2022
Julian added a commit that referenced this issue Aug 28, 2022
@Julian
Remove the TODO for draft 7 content assertions.
6693f93 
See #593 (comment)
Julian added a commit that referenced this issue Sep 9, 2022
@Julian
Squashed 'json/' changes from 6eaf7dff4..ed0b855e7
f5f839a 
ed0b855e7 Merge pull request #594 from json-schema-org/differing-uris
ae0651398 Merge pull request #593 from json-schema-org/gregsdennis-propertyDependencies-tests
0ba0976d8 more varied test cases
b78035ee5 Merge branch 'gregsdennis-propertyDependencies-tests' of github.com:json-schema-org/JSON-Schema-Test-Suite into gregsdennis-propertyDependencies-tests
8c2b46f7a rework functional tests to better illustrate purpose of keyword
33d9c6486 Update tests/draft-next/propertyDependencies.json
de3f7691f Add tests for some more differing URI scenarios.
e59510507 additional 'ignore' tests with nested matches
fc6cee5ab propertyDependencies non-string property value tests
99f3b60c1 add basic propertyDependencies tests

git-subtree-dir: json
git-subtree-split: ed0b855e7ea80c37d9295002fe436c01d9c65230
@dtkav dtkav mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Some new desired functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Julian