-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize 2.0 Release #678
Comments
The PR for merging dev-2.0 -> master is python-jsonschema/jsonschema#619 |
This comment has been minimized.
This comment has been minimized.
@dtkav thanks for the great work! |
Thanks for the bug report @ioggstream ! I'll follow that up in a separate ticket. I'd like to keep this one a bit more of a high-level discussion on what features / breaking changes should make it into Connexion 2.0. (I've hidden your comment, now that its' in python-jsonschema/jsonschema#681 - hope you don't mind!) @hjacobs and @jmcs , I would love your thoughts especially on high-level next steps! Thanks to everyone in the community who helped make these features possible ❤️ |
@hjacobs - I tend to agree. The only other thing I can think might be useful (and a breaking change) is to validate requests/responses depending on mimetype, and not only if the endpoint is purely json (i.e. python-jsonschema/jsonschema#593). |
I'm a quite new user of connexion, but I really like the project. In our setup, we already have some extensions to Draft4Validator, regarding x-nullable and readOnly (the first one with a different implementation than here). I will open seperate issues/PRs for discussion about these, but that shouldn't block the 2.0 release. |
@dtkav I'm running the specs against some files. I'll file separate issues like you did with the yaml stuff, ok? PS: Thank You for the flash fix! |
Can you have a look at dev-2.0...cziebuhr:nullable ? According to OpenAPI 3, nullable "allows sending a null value for the defined schema", so it should also work outside of properties. |
Depending on using swagger 2 / openapi 3, ConnexionOptions sets swagger_ui_local_path to swagger_ui_2_path / swagger_ui_3_path. IMHO this is only the major version of swagger-ui, swagger-ui 3 supports both swagger 2 and openapi 3. |
@cziebuhr please make a pull request! Those changes look reasonable to me.
I couldn't quite tell from your comment - are you suggesting we always serve swagger-ui-3? I'm open to that. I am aware that swagger-ui-3 is backwards compatible, but I purposefully tried to avoid changing too much about the Swagger2 development experience when adding OpenAPI3 support. Since the path is easily override-able, my thinking was to not force a major-version bump by default. I'm totally open to feedback, and happy to make the change based on what the community thinks is best. |
PR for nullable is at #684. And I have another suggestion, regarding changes in security handling: dev-2.0...cziebuhr:security
Sorry for "misusing" the dev-2.0 issue here, but I think it would be huge benefit for all connexion users and would fit into a major version bump. |
Thank @cziebuhr - I'll try to take a look at python-jsonschema/jsonschema#684 tonight. |
Opened #686 for the security rework |
Speaking in the name of OpenAPI-generator, a community fork of swagger-codegen, we are very eager to see the v2 of connexion. Our current flask-connexion generator is broken because we can only output a v3 version of the spec in the templates (OpenAPITools/openapi-generator#323). |
It's a big plus one for us as well! Looking forward to it :) |
A bit of an update:
Issues on hold:
Thanks to everyone who has been testing the dev-2.0 branch and reporting issues. It's easy to install it with:
|
I released version |
FYI: Due to python-jsonschema/jsonschema#707 if you want to install RC1 with |
I released version |
I released version |
Feature request: it would be great to have JWT support in v2.0, which seems to have been asked many times before (#607, python-jsonschema/jsonschema#389, python-jsonschema/jsonschema#124) and is part of the OpenAPI 3 spec. |
hey @lsorber , feel free to make a pull request! I'm happy to review it. We've already closed the merge window on 2.0, and I think we should get it out without any more changes (unless they are bugfixes). JWT support should be backwards compatible though right? No reason why we can't merge it in for 2.1 or some other minor release. |
FYI @lsorber , @krise3k put up this great PR (#732) for JWT support. |
@jmcs has released 2.0.0rc5 🎉 |
Big well done guys--sorry I haven't been active but I'm definitely keeping an eye. @dtkav Would you consider rc5 to be somewhat stable? I can start using it soon if so |
@JuxhinDB yes, I think it's fairly stable. Please bang on it and see if you find any issues. I've recommended that we push RC5 as the 2.0 release (and put JWT support in 2.1, which could easily be soon after). |
2.0.0 was released 🎉 https://github.com/zalando/connexion/releases/tag/2.0.0 Thanks to all contributors! |
Description
We created the dev-2.0 branch to introduce a handful of major breaking changes to connexion.
https://github.com/zalando/connexion/milestone/10
At the time, the two major changes were:
Both of these changes are now in dev-2.0
Next Steps
What other things should be in the 2.0 release? Is it large enough as is? What's could be better?
It would be great to finalize the feature set for Connexion 2.0 and get it shipped! 🚢
Let me know what you think!
The text was updated successfully, but these errors were encountered: