Remove cooldown role #2774
Merged
Remove cooldown role #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as do not merge until internal discussions are complete, please feel free to do a code review though. |
ChrisLovering
added
the
review: do not merge
The new forum-based help system implements its own cooldown system which is currently set to restrict members to a new post every 2 minutes. This restriction in addition to the much higher allowance of threads in our server, means that this help cooldown role is no longer useful. In fact, it is detrimental. Discord, in its infinite wisdom, tied the ability to change a post's name and tags to the ability to the 'Send messages' permission, meaning users with the help cooldown role were unable to complete these actions.
This ensures that if the user doesn't have the defined role, the CheckFailure raised is handled locally the way we want, rather than relying on the error-handler code
ChrisLovering
force-pushed
the
remove-cooldown-role
branch
from
65ad33d to
ccdc8ab
Compare
|
A few people have said that this is something that we want. Removing the do not merge label. |
ChrisLovering
removed
the
review: do not merge
Robin5605
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #2772 and is in discussions (internally) here
Summary
The new forum-based help system implements its own cooldown system which is currently set to restrict members to a new post every 2 minutes.
This restriction in addition to the much higher allowance of threads in our server, means that this help cooldown role is no longer useful.
In fact, it is detrimental. Discord, in its infinite wisdom, tied the ability to change a post's name and tags to the ability to the 'Send messages' permission, meaning users with the help cooldown role were unable to complete these actions.
Role out steps
After merging & deploying this change, the
Help cooldownrole should be removed from all users. The role itself and the help cooldown channel can be kept in case a rollback is desired. A staff announcement & changelog message should be made too