Give help thread owners ability to use !title command.
#2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only staff members could use the command. The implementation is a bit fragile as it depends on short-circuiting `commands.has_any_role(constants.Roles.helpers).predicate(ctx)` in the case that the user is not the OP, which would raise an exception for non-staffers instead of returning False.
Robin5605
approved these changes
Oct 1, 2023
bot/exts/help_channels/_cog.py
Outdated
|
|
||
| if ( | ||
| ctx.author.id == ctx.channel.owner_id | ||
| or await commands.has_any_role(constants.Roles.helpers).predicate(ctx) |
There was a problem hiding this comment.
Perhaps we could use this utility function? Suggested by @TizzySaurus
Suggested change
| or await commands.has_any_role(constants.Roles.helpers).predicate(ctx) | |
| or has_any_role_check(ctx, constants.Roles.helpers) |
has_any_role_check would need to be imported from bot.utils.checks import has_any_role_check
There was a problem hiding this comment.
If that solves the "The implementation is a bit fragile as it depends on short-circuiting ..." problem, then I support it.
shenanigansd
approved these changes
Oct 1, 2023
|
I'm going to refactor and push another commit--do not merge yet. |
The latter will raise an error instead of returning False, whereas the former will return a bool in either case, which is more appropriate here.
…p' into swfarnsworth/title-command-for-op
|
|
Robin5605
requested changes
Oct 1, 2023
Comment on lines
+115
to
118
| if not (user_is_op or user_is_staff): | ||
| return | ||
|
|
||
| await ctx.channel.edit(name=title) |
There was a problem hiding this comment.
Suggested change
| if not (user_is_op or user_is_staff): | |
| return | |
| await ctx.channel.edit(name=title) | |
| if user_is_op or user_is_staff: | |
| await ctx.channel.edit(name=title) |
I think not using a negative here makes the intent clearer
Merged
|
No longer needed since #2774 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only staff members could use the command. The implementation is a bit fragile as it depends on short-circuiting
commands.has_any_role(constants.Roles.helpers).predicate(ctx)in the case that the user is not the OP, which would raise an exception for non-staffers instead of returning False.