Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper pinning on tomli #8881

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Remove upper pinning on tomli #8881

merged 1 commit into from
Jul 9, 2021

Conversation

asottile
Copy link
Member

@asottile asottile commented Jul 9, 2021

the best practice is to only < when you know something is broken, and even then prefer != assuming it will be fixed upstream for maximum compatibility

the best practice is to only `<` when you know something is broken, and even then prefer `!=` assuming it will be fixed upstream for maximum compatibility
@asottile
Copy link
Member Author

asottile commented Jul 9, 2021

I'm also concerned about using a 27-star library in pytest.

@nicoddemus
Copy link
Member

I'm also concerned about using a 27-star library in pytest.

I understand but not sure that's much of a metric, given that TOML itself seems unmaintained, and tomli is gaining traction with other Python projects.

@asottile asottile enabled auto-merge July 9, 2021 14:14
@asottile
Copy link
Member Author

asottile commented Jul 9, 2021

I'm also concerned about using a 27-star library in pytest.

I understand but not sure that's much of a metric, given that TOML itself seems unmaintained, and tomli is gaining traction with other Python projects.

from the others cited in the issue nothing major has actually adopted this library yet -- we would be the first

@nicoddemus
Copy link
Member

I don't feel the same way, but if other maintainers agree, we can revert the PR.

@asottile asottile merged commit 0182eb3 into main Jul 9, 2021
@asottile asottile deleted the asottile-patch-1 branch July 9, 2021 14:27
@RonnyPfannschmidt
Copy link
Member

I also adopted it for setuptools_scm and i believe pip also adopts to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants