-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency_tree broken tomli<2.0.0,>=0.2.6, it should be using latest version 2.0.0 #2703
Comments
You'll have to downgrade your version of tomli, due to the upper bound on tomli in |
We can probably allow tomli 2 (mypy did the same recently). |
likewise pytest pytest-dev/pytest#8881 |
I'm pretty sure @hukkin, the author behind tomli, is the one who put this pin here, would probably be a good idea to ask them to weigh in. |
Black is fully compatible with Tomli v2 starting from this PR here https://github.com/psf/black/pull/2431/files Also, now that I had my one (and hopefully only) chance to make breaking changes to the API, I don't really object removing the upper pinning altogether. In case I find the need to break API in the future I'll try to do at least a year long deprecation period before. Note that PR #2408 includes moving the upper pin if you are otherwise happy with the changes there. |
BTW just out of curiosity: Do I deduce correctly from this issue that Black checks its dependency versions at runtime? Is that really necessary? Wouldn't it be better to leave dependency checking to the installer (typically |
pretty sure the error here comes at installation, the |
It doesn't. If you are talking about the |
Yes thanks for reply, We did it as of now to go further until having permanent soluton. |
The version pin was changed in #2408, this can be closed. |
The fact that it was fixed in main branch is not of much use for most users. This kind of issue is one of the few good reasons for fast-tracking a patch release. |
Now that black is a required dependency of ipython I think it would be even more important to push a new release rather sooner than later. |
We're releasing this week! But do note that it's our first non-beta, so it can't really be expedited. |
That's great to hear, thank you ❤️! |
is there any workaround? |
could install directly from GitHub, |
Describe the bug
black 21.12b0 requires tomli<2.0.0,>=0.2.6, but you have tomli 2.0.0 which is incompatible.
To Reproduce
For example, take this code:
And run it with these arguments:
The resulting error is:
Expected behavior
Environment
Additional context
The text was updated successfully, but these errors were encountered: