Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disable_test_id_escaping_and_forfeit_all_rights_to_community_support option when using a list of test IDs #5294

Merged
merged 2 commits into from
May 21, 2019
Merged

Fix disable_test_id_escaping_and_forfeit_all_rights_to_community_support option when using a list of test IDs #5294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a304dbb
Fix `disable_test_id_escaping_and_forfeit_all_rights_to_community_sup…
akiomik May 21, 2019
8a49870
Add tests for #5286
akiomik May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Abhijeet Kasurde
Adam Johnson
Adam Uhlir
Ahn Ki-Wook
Akiomi Kamakura
Alan Velasco
Alexander Johnson
Alexei Kozlenok
Expand Down
1 change: 1 addition & 0 deletions changelog/5286.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix issue with ``disable_test_id_escaping_and_forfeit_all_rights_to_community_support`` option doesn't work when using a list of test IDs in parametrized tests.
2 changes: 1 addition & 1 deletion src/_pytest/python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,7 @@ def _idvalset(idx, parameterset, argnames, idfn, ids, item, config):
]
return "-".join(this_id)
else:
return ascii_escaped(ids[idx])
return _ascii_escaped_by_config(ids[idx], config)


def idmaker(argnames, parametersets, idfn=None, ids=None, config=None, item=None):
Expand Down