-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disable_test_id_escaping_and_forfeit_all_rights_to_community_support
option when using a list of test IDs
#5294
Fix disable_test_id_escaping_and_forfeit_all_rights_to_community_support
option when using a list of test IDs
#5294
Conversation
…port` option when using a list of test IDs
Codecov Report
@@ Coverage Diff @@
## master #5294 +/- ##
==========================================
+ Coverage 91.45% 91.53% +0.08%
==========================================
Files 115 115
Lines 26165 26212 +47
Branches 2578 2582 +4
==========================================
+ Hits 23928 23993 +65
+ Misses 1916 1894 -22
- Partials 321 325 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @asottile mentions, please add a test so we avoid future regressions. 👍
Added some tests 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akiomik, great contribution!
Fixes #5286 .