Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable_test_id_escaping_and_forfeit_all_rights_to_community_support option when using a list of test IDs #5294

Merged

Conversation

akiomik
Copy link
Contributor

@akiomik akiomik commented May 21, 2019

Fixes #5286 .

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #5294 into master will increase coverage by 0.08%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5294      +/-   ##
==========================================
+ Coverage   91.45%   91.53%   +0.08%     
==========================================
  Files         115      115              
  Lines       26165    26212      +47     
  Branches     2578     2582       +4     
==========================================
+ Hits        23928    23993      +65     
+ Misses       1916     1894      -22     
- Partials      321      325       +4
Impacted Files Coverage Δ
src/_pytest/python.py 92.97% <100%> (-0.13%) ⬇️
testing/python/metafunc.py 90.86% <91.48%> (-1.05%) ⬇️
testing/python/show_fixtures_per_test.py 85.29% <0%> (-14.71%) ⬇️
testing/test_terminal.py 86.15% <0%> (-11.98%) ⬇️
testing/python/integration.py 82.14% <0%> (-9.29%) ⬇️
testing/python/setup_only.py 94.64% <0%> (-5.36%) ⬇️
src/_pytest/terminal.py 91.77% <0%> (-1.68%) ⬇️
testing/test_warnings.py 97.26% <0%> (-1.64%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6663cb0...8a49870. Read the comment docs.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, should we add a small demo test for this "feature" (we currently don't have any showing whether it works or not) -- or naah and leave it to "community support 🤣

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @asottile mentions, please add a test so we avoid future regressions. 👍

@akiomik
Copy link
Contributor Author

akiomik commented May 21, 2019

Added some tests 🙂

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akiomik, great contribution!

@asottile asottile merged commit de7ba59 into pytest-dev:master May 21, 2019
@akiomik akiomik deleted the fix-disable_test_id_escaping-option branch May 21, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable_test_id_escaping_and_forfeit_all_rights_to_community_support doesn't work when using list of IDs
3 participants