Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out list of essential plugins #5005

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 27, 2019

No changelog, since this is meant to be internal/private? (rename to _essential_plugins maybe?)

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #5005 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5005      +/-   ##
============================================
+ Coverage     96.06%   96.06%   +<.01%     
============================================
  Files           114      114              
  Lines         25745    25753       +8     
  Branches       2548     2551       +3     
============================================
+ Hits          24731    24739       +8     
  Misses          704      704              
  Partials        310      310
Impacted Files Coverage Δ
src/_pytest/config/__init__.py 94.43% <100%> (+0.02%) ⬆️
src/_pytest/terminal.py 92.45% <100%> (ø) ⬆️
testing/test_config.py 99.48% <100%> (ø) ⬆️
testing/test_pluginmanager.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9dcf1...8c734df. Read the comment docs.

@blueyed blueyed changed the title Split out list of essential plugins WIP: Split out list of essential plugins Mar 27, 2019
@blueyed blueyed added this to the 4.5 milestone Apr 2, 2019
@blueyed blueyed changed the title WIP: Split out list of essential plugins Split out list of essential plugins Apr 2, 2019
@blueyed blueyed requested a review from nicoddemus April 2, 2019 15:32
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blueyed blueyed merged commit 32a8d50 into pytest-dev:features Apr 3, 2019
@blueyed blueyed deleted the essential_plugins branch April 3, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants