Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add essential_plugins list, split out of default_plugins #4976

Closed
blueyed opened this issue Mar 22, 2019 · 1 comment
Closed

config: add essential_plugins list, split out of default_plugins #4976

blueyed opened this issue Mar 22, 2019 · 1 comment
Labels
type: refactoring internal improvements to the code

Comments

@blueyed
Copy link
Contributor

blueyed commented Mar 22, 2019

Agree about having two lists, and while at it, we should also stop running with a clear message if one of the essential plugins is passed to -p no:, "this internal plugin is essential for pytest function and cannot be blocked".

I would put those plugins in a list essential_plugins, and just make default_plugins a sum of the essential plugins with the rest:

essential_plugins = (
    "fixtures",
    "helpconfig",  # Provides -p.
    ...
)

default_plugins = essential_plugins + (    
    "debugging",
    "unittest", 
    ...
)    

But I believe this is better done in a separate PR, don't you agree?

Originally posted by @nicoddemus in #4965

@nicoddemus nicoddemus added the type: refactoring internal improvements to the code label Mar 22, 2019
blueyed added a commit to blueyed/pytest that referenced this issue Mar 27, 2019
blueyed added a commit to blueyed/pytest that referenced this issue Mar 27, 2019
blueyed added a commit to blueyed/pytest that referenced this issue Mar 27, 2019
blueyed added a commit to blueyed/pytest that referenced this issue Apr 2, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Apr 13, 2019

Done in #5005.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring internal improvements to the code
Projects
None yet
Development

No branches or pull requests

2 participants