Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependabot config #419

Closed
wants to merge 1 commit into from
Closed

Add dependabot config #419

wants to merge 1 commit into from

Conversation

BeyondEvil
Copy link
Contributor

No description provided.

@gnikonorov gnikonorov mentioned this pull request Dec 13, 2020
Merged
@gnikonorov
Copy link
Member

Do we need to wait on an answer for dependabot/dependabot-core#2040 before we can merge this?

It sounds like dependabot/dependabot-core#1524 is not a concern, right?

@gnikonorov gnikonorov added Infrastructure Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. ) skip-changelog Can be missed from the changelog. labels Dec 13, 2020
@BeyondEvil
Copy link
Contributor Author

Do we need to wait on an answer for dependabot/dependabot-core#2040 before we can merge this?

Well, we have additional_dependencies in our pre-commit config... so 🤷‍♂️

It sounds like dependabot/dependabot-core#1524 is not a concern, right?

Umm... that's the main functionality of keeping pre-commit config up-to-date by using dependabot, so not sure what you mean? 😊

@gnikonorov
Copy link
Member

It sounds like dependabot/dependabot-core#1524 is not a concern, right?

Umm... that's the main functionality of keeping pre-commit config up-to-date by using dependabot, so not sure what you mean? 😊

I'm referencing dependabot/dependabot-core#1524 (comment)

@BeyondEvil
Copy link
Contributor Author

It sounds like dependabot/dependabot-core#1524 is not a concern, right?

Umm... that's the main functionality of keeping pre-commit config up-to-date by using dependabot, so not sure what you mean? 😊

I'm referencing dependabot/dependabot-core#1524 (comment)

Ah!

Well, I turned it on for the repo. But I'm going to turn it off again. After some thought I don't want to maintain two different solutions that are tightly coupled. Since we likely won't bump these dev-dependencies very often, I'm just going to add comments to both places to remember.

@BeyondEvil BeyondEvil closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

@gnikonorov gnikonorov Awaiting requested review from gnikonorov

Assignees

@BeyondEvil BeyondEvil

Labels
Infrastructure Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. ) skip-changelog Can be missed from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeyondEvil @gnikonorov